🧘🏻 ensure field is focused when selected (#8566)

As noted by MDN, calling `element.select()` doesn’t necessarily focus the element. As such, they recommend calling `element.focus()` too. See https://developer.mozilla.org/en-US/docs/Web/API/HTMLInputElement/select#notes
react-hook-form · Jun 24, 2022 · 6ec36a8 · 6ec36a8
1 parent d3fa1b1
commit 6ec36a8
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/__tests__/useController.test.tsx b/src/__tests__/useController.test.tsx
@@ -665,7 +665,6 @@ describe('useController', () => {
       });
 
       React.useEffect(() => {
-        setFocus('test');
         setFocus('test', { shouldSelect: true });
       }, [setFocus]);
 

diff --git a/src/logic/createFormControl.ts b/src/logic/createFormControl.ts
@@ -1204,7 +1204,8 @@ export function createFormControl<
   const setFocus: UseFormSetFocus<TFieldValues> = (name, options = {}) => {
     const field = get(_fields, name)._f;
     const fieldRef = field.refs ? field.refs[0] : field.ref;
-    options.shouldSelect ? fieldRef.select() : fieldRef.focus();
+    fieldRef.focus();
+    options.shouldSelect && fieldRef.select();
   };
 
   return {