Skip to content

Commit

Permalink
馃珫 prevent reset argument mutation (#10847)
Browse files Browse the repository at this point in the history
* breaking test case

* avoid argument assignment to internal variable
  • Loading branch information
jgullstr committed Aug 25, 2023
1 parent 390c01e commit 89a3584
Show file tree
Hide file tree
Showing 2 changed files with 33 additions and 1 deletion.
32 changes: 32 additions & 0 deletions src/__tests__/useForm/reset.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -1508,3 +1508,35 @@ describe('reset', () => {
expect(screen.getByText('useWatch: anything')).toBeVisible();
});
});

it('should not mutate data outside of library', () => {
const defaultValues = {
test: 'ok',
};

const App = () => {
const { register, reset, resetField } = useForm();

return (
<form>
<input {...register('test')} />
<button type="button" onClick={() => reset(defaultValues)}>
reset
</button>
<button
type="button"
onClick={() => resetField('test', { defaultValue: 'error' })}
>
resetField
</button>
</form>
);
};

render(<App />);

fireEvent.click(screen.getByRole('button', { name: 'reset' }));
fireEvent.click(screen.getByRole('button', { name: 'resetField' }));

expect(defaultValues.test).toBe('ok');
});
2 changes: 1 addition & 1 deletion src/logic/createFormControl.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1138,7 +1138,7 @@ export function createFormControl<
formValues,
keepStateOptions = {},
) => {
const updatedValues = formValues || _defaultValues;
const updatedValues = formValues ? cloneObject(formValues) : _defaultValues;
const cloneUpdatedValues = cloneObject(updatedValues);
const values =
formValues && !isEmptyObject(formValues)
Expand Down

0 comments on commit 89a3584

Please sign in to comment.