🕵️‍♀️ improve logic on register absent inputs (#5556)

* improve logic on register absent inputs

* rename variable

* remove any and update with test

src/__tests__/useForm/getValues.test.tsx

@@ -200,6 +200,8 @@ describe('getValues', () => {
           test: {
             firstName: 'test',
             lastName: 'test',
+            time: new Date('1999-09-09'),
+            file: new File([''], 'filename'),
           },
         },
       });
@@ -228,6 +230,8 @@ describe('getValues', () => {
       test: {
         firstName: 'test',
         lastName: 'test',
+        time: new Date('1999-09-09'),
+        file: new File([''], 'filename'),
       },
     });
 
@@ -241,7 +245,7 @@ describe('getValues', () => {
       fireEvent.click(screen.getByRole('button'));
     });
 
-    expect(data).toEqual({
+    expect(data).toMatchObject({
       test: {
         firstName: '1234',
         lastName: 'test',

src/__tests__/useForm/setValue.test.tsx

@@ -4,6 +4,7 @@ import {
   fireEvent,
   render,
   screen,
+  waitFor,
 } from '@testing-library/react';
 import { act, renderHook } from '@testing-library/react-hooks';
 
@@ -1052,4 +1053,28 @@ describe('setValue', () => {
       });
     });
   });
+
+  it('should only be able to update value of array of inputs which is not registered', async () => {
+    const App = () => {
+      const { setValue, watch } = useForm({
+        defaultValues: {
+          test: ['1', '2', '3'],
+        },
+      });
+
+      React.useEffect(() => {
+        setValue('test', ['2', '2']);
+      }, [setValue]);
+
+      const result = watch('test');
+
+      return <p>{JSON.stringify(result)}</p>;
+    };
+
+    render(<App />);
+
+    await waitFor(async () => {
+      screen.getByText('["2","2","3"]');
+    });
+  });
 });

src/useForm.ts

@@ -1029,27 +1029,19 @@ export function useForm<
   );
 
   const registerAbsentFields = <T extends DefaultValues<TFieldValues>>(
-    value: T,
+    defaultValues: T,
     name = '',
   ): void => {
-    const field = get(fieldsRef.current, name);
-
-    if (!field || (field && !field._f)) {
-      if (
-        !field &&
-        (isPrimitive(value) ||
-          (isWeb && (value instanceof FileList || value instanceof Date)))
-      ) {
-        register(name as Path<TFieldValues>, { value } as RegisterOptions);
-      }
-
-      if (Array.isArray(value) || isObject(value)) {
-        if (name && !get(fieldsRef.current, name)) {
-          set(fieldsRef.current, name, Array.isArray(value) ? [] : {});
-        }
-
-        for (const key in value) {
-          registerAbsentFields(value[key], name + (name ? '.' : '') + key);
+    for (const key in defaultValues) {
+      const value = defaultValues[key];
+      const fieldName = name + (name ? '.' : '') + key;
+      const field = get(fieldsRef.current, fieldName);
+
+      if (!field || !field._f) {
+        if (isObject(value) || Array.isArray(value)) {
+          registerAbsentFields(value, fieldName);
+        } else if (!field) {
+          register(fieldName as Path<TFieldValues>, { value });
         }
       }
     }