feat: change the onValid argument of handleSubmit to optional

react-hook-form · Oct 17, 2023 · ec8e19e · ec8e19e
1 parent 21c13aa
commit ec8e19e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/logic/createFormControl.ts b/src/logic/createFormControl.ts
@@ -1100,7 +1100,9 @@ export function createFormControl<
         _subjects.state.next({
           errors: {},
         });
-        await onValid(fieldValues as TFieldValues, e);
+        if (onValid) {
+          await onValid(fieldValues as TFieldValues, e);
+        }
       } else {
         if (onInvalid) {
           await onInvalid({ ..._formState.errors }, e);

diff --git a/src/types/form.ts b/src/types/form.ts
@@ -620,7 +620,7 @@ export type UseFormHandleSubmit<
   TFieldValues extends FieldValues,
   TTransformedValues extends FieldValues | undefined = undefined,
 > = (
-  onValid: TTransformedValues extends FieldValues
+  onValid?: TTransformedValues extends FieldValues
     ? SubmitHandler<TTransformedValues>
     : SubmitHandler<TFieldValues>,
   onInvalid?: SubmitErrorHandler<TFieldValues>,