Skip to content

Commit

Permalink
🏷️ improve CustomElement type (#11309)
Browse files Browse the repository at this point in the history
* 🏷️ improve CustomElement type

* 🏷️ Change HTMLElement to Partial

* 📝 fix api-extractor

---------

Co-authored-by: Beier (Bill) <bluebill1049@hotmail.com>
  • Loading branch information
r-kataoka11 and bluebill1049 committed Jan 15, 2024
1 parent f18c147 commit f8bbb30
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 11 deletions.
2 changes: 1 addition & 1 deletion reports/api-extractor.md
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ export type ControllerRenderProps<TFieldValues extends FieldValues = FieldValues
export type CriteriaMode = 'firstError' | 'all';

// @public (undocumented)
export type CustomElement<TFieldValues extends FieldValues> = {
export type CustomElement<TFieldValues extends FieldValues> = Partial<HTMLElement> & {
name: FieldName<TFieldValues>;
type?: string;
value?: any;
Expand Down
21 changes: 11 additions & 10 deletions src/types/fields.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,16 +8,17 @@ export type FieldName<TFieldValues extends FieldValues> =
? Extract<keyof TFieldValues, string>
: string;

export type CustomElement<TFieldValues extends FieldValues> = {
name: FieldName<TFieldValues>;
type?: string;
value?: any;
disabled?: boolean;
checked?: boolean;
options?: HTMLOptionsCollection;
files?: FileList | null;
focus?: Noop;
};
export type CustomElement<TFieldValues extends FieldValues> =
Partial<HTMLElement> & {
name: FieldName<TFieldValues>;
type?: string;
value?: any;
disabled?: boolean;
checked?: boolean;
options?: HTMLOptionsCollection;
files?: FileList | null;
focus?: Noop;
};

export type FieldValue<TFieldValues extends FieldValues> =
TFieldValues[InternalFieldName];
Expand Down

0 comments on commit f8bbb30

Please sign in to comment.