issue: Usage of useController hook, change isDirty state for form to true.

[sshmyg]

Version Number

7.43.7

Codesandbox/Expo snack

https://codesandbox.io/s/react-hook-form-get-started-forked-d470cp?file=/src/index.js:239-246

Steps to reproduce

1. Open https://codesandbox.io/s/react-hook-form-get-started-forked-d470cp?file=/src/index.js:239-246
2. See console log with 2 messages, first with isDirty as false and second - true.

Expected behaviour

Initial render shouldn't change isDirty for form.

What browsers are you seeing the problem on?

Chrome

Relevant log output

No response

Code of Conduct

• I agree to follow this project's Code of Conduct

[bluebill1049]

expected behaviour as your formValues is no longer match your defaultValues

[sshmyg]

@bluebill1049 Why dirtyFields param is empty then?

[sshmyg]

@bluebill1049 And why formValues not match with defaultValues on first load?

[bluebill1049]

Please don't tag me twice, I have loads of notifications try to keep up to date.

@bluebill1049 And why formValues not match with defaultValues on first load?

because input gets register at render.

@bluebill1049 Why dirtyFields param is empty then?

This something we can improve.

[sshmyg]

Thnks, sorry for tags :)

[sshmyg]

Don't you think register and useController should have same behaviour? I mean if register doesn't change isDirty, useController shouldn't either? Or both should change.

[bluebill1049]

useController called before render.

[sshmyg]

So you think different behaviour is ok?
Maybe this difference need to be mentioned in doc or something. It's not obvious.

[bluebill1049]

It would be best if you always considered providing the entire default state for your entire form. In fact, this has been listed in the formState isDirty section: https://react-hook-form.com/api/useform/formstate/

[sshmyg]

I think react-hook-forms should not convert undefined to empty string for input values. React has warning for this, but with this implicit conversion, developer has no idea about this, and gets such unpredictable situation.

[bluebill1049]

That's unless we remove all the inline defaultValue, defaultCheck support.

[bluebill1049]

Spend some time with this issue, I am going to keep it as it is for now as mark it as a design limitation. Yes, in hook form defeaultValues will be the source of truth to mark dirty fields and dirty values. I will include this information in the doc, to info the developer to include defaultValues to have better dirty tracking and consistent output. Probably going to dismiss this PR as well #10152 as it won't change the nature of importance of defaultVlaues for react hook form.

react-hook-form/documentation@8f92ebb