fix(useForm): leave formState flags in a consistent state when throwing in handleSubmit onValid

[anonkey]

Proposed Changes

onValid function given to handleSubmit from useForm is often the way to send request to server but when this function throw it leave isSubmitting flag true and isSubmitted flag on false what is inconsistent.

This change keep the current behavior of bubbling up the error but fix the inconsistent formState

Fixes #11084

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing tests pass locally with my changes

[codesandbox]

Review or Edit in CodeSandbox

Open the branch in Web Editor • VS Code • Insiders

Open Preview

[anonkey]

Had problem to run
pnpm tsd and pnpm e2e locally
Hope this will be checked by CI

[bluebill1049]

thanks for the PR, i think this is what i had before but users complain about errors being swallowed by handleSubmit.

[anonkey]

With this there is still error bubbling up just it set the isSubmitting state before rethrowing the error, no swallow happens

[anonkey]

Since error are not swallowed like before, is there any chance to have this MR merged ?

[bluebill1049]

LGTM. let me know if you are happy with this as well @Moshyfawn

[Moshyfawn]

LGTM. let me know if you are happy with this as well @Moshyfawn

This is fine as a behaviour fix 👍

[anonkey]

Thanks a lot for the PR and for your work

[pianomansam]

When will this get released?

Pardon my ignorance, as I'm a user of the project and not yet a contributor. I stumbled across this issue because I'm experiencing isSubmitting still being true after a rejected promise in the onSubmit handler.