-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V8 (LazyPath to be reverted) #5941
Conversation
Size Change: +289 B (+2%) Total Size: 17.9 kB
|
@bluebill1049 Will the React Hook Form work in React 18? I'm interested in this PR 😎 |
Yea, it should be compatible with 18. I am try to test it out, last time the automation actually all pass except the onBlur even has some issue with useEffect which I had raised an issue in react 18 discussion group. So far looks promising. |
The issue: reactwg/react-18#40 which i have posted on React-18 group discussion. |
There seems to be some config issue with the CSB CI integration still, as I've tried to do the same in my fork of RHF and it works flawlessly. Notice that in my fork, all the other CI checks like package size and API extractor don't work.. hm |
feel free to check old commits, i did made it working before :) |
The only diff is that the config contains the {
+ "sandboxes": [
+ "react-hook-form-v7-js-template-quqov",
+ "react-hook-form-v7-ts-template-4tn8i"
+ ],
- "buildCommand": "build",
+ "node": "14"
} Again, it works in RHF fork, which is interesting.. Do you mind checking the GH CSB CI app and maybe "reconnect" it with the repo? IDK why it would only work in a fork of the same lib with the same config other than because of some weirdness with the GH app |
Did a re-config with CSB @Moshyfawn |
Yas, it worked! #8278 |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 9f84d26:
|
Plan to move into |
update: currently blocked by TS 4.7.0 it brought a breaking change to the lazy type. |
@bluebill1049 there is a PR open in TypeScript microsoft/TypeScript#52997 to fix the issue with LazyPaths. They will work fine once again. |
oh that's awesome to hear @itsUndefined cc @felixschorer |
@bluebill1049 fix landed on TS 5.3 so this feature can return on the development of V8? |
What is the current status of this? Are there plans to merge this PR now that the TypeScript bug has been fixed? |
V8
RFC: #7433