Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V8 (LazyPath to be reverted) #5941

Closed
wants to merge 132 commits into from
Closed

V8 (LazyPath to be reverted) #5941

wants to merge 132 commits into from

Conversation

bluebill1049
Copy link
Member

@bluebill1049 bluebill1049 commented Jul 14, 2021

V8

RFC: #7433

@github-actions
Copy link
Contributor

github-actions bot commented Jul 14, 2021

Size Change: +289 B (+2%)

Total Size: 17.9 kB

Filename Size Change
dist/index.cjs.js 8.91 kB +149 B (+2%)
dist/index.umd.js 9 kB +140 B (+2%)

compressed-size-action

@kotarella1110
Copy link
Member

@bluebill1049 Will the React Hook Form work in React 18? I'm interested in this PR 😎

@bluebill1049
Copy link
Member Author

@bluebill1049 Will the React Hook Form work in React 18? I'm interested in this PR 😎

Yea, it should be compatible with 18. I am try to test it out, last time the automation actually all pass except the onBlur even has some issue with useEffect which I had raised an issue in react 18 discussion group. So far looks promising.

@bluebill1049
Copy link
Member Author

The issue: reactwg/react-18#40 which i have posted on React-18 group discussion.

@Moshyfawn
Copy link
Member

Moshyfawn commented Apr 30, 2022

There seems to be some config issue with the CSB CI integration still, as I've tried to do the same in my fork of RHF and it works flawlessly.

Notice that in my fork, all the other CI checks like package size and API extractor don't work.. hm

@bluebill1049
Copy link
Member Author

There seems to be some config issue with the CSB CI integration still, as I've tried to do the same in my fork of RHF and it works flawlessly

feel free to check old commits, i did made it working before :)

@Moshyfawn
Copy link
Member

The only diff is that the config contains the buildCommand and the node version (which shouldn't influence anything, really):

 {
+ "sandboxes": [
+ "react-hook-form-v7-js-template-quqov",
+ "react-hook-form-v7-ts-template-4tn8i"
+ ],
- "buildCommand": "build",
+ "node": "14"
 }

Again, it works in RHF fork, which is interesting..

Do you mind checking the GH CSB CI app and maybe "reconnect" it with the repo? IDK why it would only work in a fork of the same lib with the same config other than because of some weirdness with the GH app

@bluebill1049
Copy link
Member Author

Did a re-config with CSB @Moshyfawn

@Moshyfawn
Copy link
Member

Yas, it worked! #8278

image

@codesandbox-ci
Copy link

codesandbox-ci bot commented May 2, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9f84d26:

Sandbox Source
React Hook Form V7 (JS) Template Configuration
React Hook Form V7 (TS) Template Configuration

@bluebill1049
Copy link
Member Author

Plan to move into beta once useEvent releases.

@bluebill1049
Copy link
Member Author

update: currently blocked by TS 4.7.0 it brought a breaking change to the lazy type.

@bluebill1049 bluebill1049 marked this pull request as draft June 18, 2022 04:55
@bluebill1049 bluebill1049 changed the title V8 V8 (To be reverted) Jun 18, 2022
@bluebill1049 bluebill1049 changed the title V8 (To be reverted) V8 (LazyPath to be reverted) Jun 18, 2022
@leapful leapful deleted the react-18 branch December 10, 2022 02:06
@itsUndefined
Copy link

@bluebill1049 there is a PR open in TypeScript microsoft/TypeScript#52997 to fix the issue with LazyPaths. They will work fine once again.

@bluebill1049
Copy link
Member Author

oh that's awesome to hear @itsUndefined cc @felixschorer

@itsUndefined
Copy link

@bluebill1049 fix landed on TS 5.3 so this feature can return on the development of V8?

@BrendanC23
Copy link

What is the current status of this? Are there plans to merge this PR now that the TypeScript bug has been fixed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.