Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悶 fix #11368 keep form state mounted when keeping values #11384

Merged
merged 5 commits into from
Jan 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
96 changes: 68 additions & 28 deletions src/__tests__/useForm/reset.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -1522,36 +1522,76 @@ describe('reset', () => {
expect(screen.getByText('watch: anything')).toBeVisible();
expect(screen.getByText('useWatch: anything')).toBeVisible();
});
});

it('should not mutate data outside of library', () => {
const defaultValues = {
test: 'ok',
};

const App = () => {
const { register, reset, resetField } = useForm();

return (
<form>
<input {...register('test')} />
<button type="button" onClick={() => reset(defaultValues)}>
reset
</button>
<button
type="button"
onClick={() => resetField('test', { defaultValue: 'error' })}
>
resetField
</button>
</form>
);
};
it('should keep mounted value after reset with keep dirty values', async () => {
function App() {
const {
getValues,
reset,
register,
formState: { isValid },
} = useForm({
mode: 'onChange',
});

return (
<form>
<input
{...register('value', { required: true })}
defaultValue="Any default value!"
/>
<p>{getValues().test}</p>
<p>isValid = {isValid ? 'true' : 'false'}</p>
<button
type="button"
onClick={() => reset({ test: '34' }, { keepDirtyValues: true })}
>
reset
</button>
</form>
);
}

render(<App />);

expect(await screen.findByText('isValid = true')).toBeVisible();

fireEvent.click(screen.getByRole('button'));

await waitFor(() => {
screen.getByText('34');
});
});

it('should not mutate data outside of library', () => {
const defaultValues = {
test: 'ok',
};

const App = () => {
const { register, reset, resetField } = useForm();

return (
<form>
<input {...register('test')} />
<button type="button" onClick={() => reset(defaultValues)}>
reset
</button>
<button
type="button"
onClick={() => resetField('test', { defaultValue: 'error' })}
>
resetField
</button>
</form>
);
};

render(<App />);
render(<App />);

fireEvent.click(screen.getByRole('button', { name: 'reset' }));
fireEvent.click(screen.getByRole('button', { name: 'resetField' }));
fireEvent.click(screen.getByRole('button', { name: 'reset' }));
fireEvent.click(screen.getByRole('button', { name: 'resetField' }));

expect(defaultValues.test).toBe('ok');
expect(defaultValues.test).toBe('ok');
});
});
5 changes: 4 additions & 1 deletion src/logic/createFormControl.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1249,7 +1249,10 @@ export function createFormControl<

!_state.mount && flushRootRender();

_state.mount = !_proxyFormState.isValid || !!keepStateOptions.keepIsValid;
_state.mount =
!_proxyFormState.isValid ||
!!keepStateOptions.keepIsValid ||
!!keepStateOptions.keepDirtyValues;

_state.watch = !!props.shouldUnregister;

Expand Down