fix/improve setError & clearError #1907

bluebill1049 · 2020-06-18T12:47:50Z

setError

setError will focus one error at a time and remove confusing set multiple errors, behavior change.

setError will persis an error if it's not part of the form, which requires manual remove with clearError
setError error will be removed by validation rules, rules always take over errors

Reason

should focus an error at a time just like the name suggested, refine the API and remove multiple errors set.

- setError('test', 'test', 'test')
+ setErrror('test', { type: 'test, message: 'bill'})

clearError

Rename to clearErrors

Reason

This function allow remove multiple errors, so make sense to rename it to clearErrors

- clearError()
+ clearErrors()

fix #1908

github-actions · 2020-06-18T22:20:27Z

Size Change: -597 B (0%)

Total Size: 70.5 kB

Filename	Size	Change
`dist/react-hook-form.es.js`	14.3 kB	-119 B (0%)
`dist/react-hook-form.ie11.js`	18.1 kB	-117 B (0%)
`dist/react-hook-form.js`	14.3 kB	-134 B (0%)
`dist/react-hook-form.min.es.js`	9.18 kB	-77 B (0%)
`dist/react-hook-form.umd.js`	14.6 kB	-150 B (1%)

_{compressed-size-action}

codesandbox-ci · 2020-06-18T22:52:41Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b09faa9:

Sandbox	Source
ecstatic-napier-uzytp	Configuration
React Hook Form - Set Error / Clear Error	Issue #1908
React Hook Form - Set Error / Clear Error	Issue #1908

JeromeDeLeon · 2020-06-19T00:22:13Z

I think we could go back to this and setValue when users wanted setValues and setErrors to be implemented without the cause of extra re-renders, but I think it's fine for to make consistency around the API. 👍

bluebill1049 · 2020-06-19T00:24:10Z

I think we could go back to this and setValue when users wanted setValues and setErrors to be implemented without the cause of extra re-renders, but I think it's fine for to make consistency around the API. 👍

Totally agree, otherwise the API name is very confusing against its functionality.

['xxx', 'tss'].map(setError) should do the job

if users complains about the multiple re-render, we can then consider introducing setValues setErrors, ideally to avoid.

JeromeDeLeon · 2020-06-19T04:17:21Z

src/types/form.ts

+          types: MultipleFieldErrors;
+        }
+      | {
+          message?: Message;


curious tho why is it message is not required?

just like register({ required: true })

Ahh make sense. 😆

JeromeDeLeon · 2020-06-19T04:21:12Z

src/useForm.ts

+      | {
+          message?: Message;
+          type: string;
+        },


could we create type ErrorOption or Error to reduce redundancy in type?

sounds good to me 👍

will do that after work :)

I could do it for you. 😄

commit please! 💋

first-time see 8 in months...

keiya01

I'm sorry for the delay in my review🙏

keiya01 · 2020-06-19T04:19:24Z

src/useForm.ts

-        shouldRender: true,
-      });
-    }
+    setInternalError({


setInternalError method is used inside only setError method. I think you can expand setInternalError method to setError method.

oh man! totally!

Man! didn't notice it before! 😆

Thanks @keiya01

we are 8 again. lol

I miss when the lib was 2k tho lol

It just means it becoming useful to others because they want to stick with it and push some new features to us. 😄

keiya01 · 2020-06-19T04:25:43Z

src/logic/shouldRenderBasedOnError.ts

@@ -28,10 +28,7 @@ export default function shouldRenderBasedOnError<
  const currentFieldError = get(error, name);


isManual is used inside unit test. I think you had better remove this variables from unit test.

JeromeDeLeon · 2020-06-19T05:09:01Z

Haha you got me first @bluebill1049

bluebill1049 · 2020-06-19T05:09:46Z

Haha you got me first @bluebill1049

Thanks for your help @JeromeDeLeon 🙏

JeromeDeLeon · 2020-06-19T05:11:02Z

Nah. It was nothing compared to you. My laptop stopped responding when I was about to test locally 🤯🤯

keiya01

It's nice to have less code :)

keiya01 · 2020-06-19T05:22:37Z

src/useForm.ts

-      }
-    }
-  };
-
  function setError(name: FieldName<TFieldValues>, error: ErrorOption): void {


bluebill1049 · 2020-06-19T06:27:51Z

@keiya01 @JeromeDeLeon happy to approve?

bluebill1049 · 2020-06-19T06:38:09Z

Thanks guys for the review.

2DSharp · 2020-06-19T08:28:02Z

I think that would make things clearer, thanks @bluebill1049

AEPKILL · 2020-11-13T02:39:46Z

src/useForm.ts

          errorsRef.current = {};
          reRender();
          await callback(transformToNestObject(fieldValues), e);
        } else {
-          errorsRef.current = fieldErrors;
+          errorsRef.current = {


why need to merge the old error state?

fix setError

ddc699d

bluebill1049 added the status: working in progress working in progress label Jun 18, 2020

pass unit tests

9c2415b

fix automation

e85a20e

bluebill1049 added 2 commits June 19, 2020 08:59

fix test and automtation

c7aa767

prevent submit error if setError set an input is not revaldiated

61797ff

bluebill1049 mentioned this pull request Jun 18, 2020

calling setError() on submit shows error, but is reset as element loses focus #1881

Closed

include unit test

99cf677

bluebill1049 requested review from kotarella1110, keiya01, stramel and JeromeDeLeon and removed request for kotarella1110 June 19, 2020 00:02

bluebill1049 removed the status: working in progress working in progress label Jun 19, 2020

bluebill1049 changed the title ~~fix setError~~ fix/improve setError & clearError Jun 19, 2020

bluebill1049 added 2 commits June 19, 2020 13:29

fix type for setError

cda4dae

fix type

da162aa

JeromeDeLeon reviewed Jun 19, 2020

View reviewed changes

keiya01 reviewed Jun 19, 2020

View reviewed changes

JeromeDeLeon and others added 2 commits June 19, 2020 12:46

🎨 Reduce type redundancy

88033f6

fix setError and unit test

6d8ec77

fix issue caught by automation

81a1d80

keiya01 reviewed Jun 19, 2020

View reviewed changes

fix unit tests

b09faa9

JeromeDeLeon approved these changes Jun 19, 2020

View reviewed changes

bluebill1049 merged commit acd6214 into master Jun 19, 2020

bluebill1049 deleted the feature/fix-setError branch June 19, 2020 06:37

natac13 mentioned this pull request Jun 28, 2020

setError with multiple fields #1987

Closed

henry-young mentioned this pull request Jul 13, 2020

Unable to submit when non-registered field has error - Possible regression v5->v6 #2180

Closed

AEPKILL reviewed Nov 13, 2020

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix/improve setError & clearError #1907

fix/improve setError & clearError #1907

bluebill1049 commented Jun 18, 2020 •

edited

github-actions bot commented Jun 18, 2020 •

edited

codesandbox-ci bot commented Jun 18, 2020 •

edited

JeromeDeLeon commented Jun 19, 2020

bluebill1049 commented Jun 19, 2020

JeromeDeLeon Jun 19, 2020

bluebill1049 Jun 19, 2020

JeromeDeLeon Jun 19, 2020

JeromeDeLeon Jun 19, 2020

bluebill1049 Jun 19, 2020

bluebill1049 Jun 19, 2020

JeromeDeLeon Jun 19, 2020 •

edited

bluebill1049 Jun 19, 2020

bluebill1049 Jun 19, 2020

keiya01 left a comment

keiya01 Jun 19, 2020

bluebill1049 Jun 19, 2020

JeromeDeLeon Jun 19, 2020

bluebill1049 Jun 19, 2020

bluebill1049 Jun 19, 2020

JeromeDeLeon Jun 19, 2020

keiya01 Jun 19, 2020

JeromeDeLeon commented Jun 19, 2020

bluebill1049 commented Jun 19, 2020

JeromeDeLeon commented Jun 19, 2020

keiya01 left a comment

keiya01 Jun 19, 2020

bluebill1049 commented Jun 19, 2020

bluebill1049 commented Jun 19, 2020

2DSharp commented Jun 19, 2020

AEPKILL Nov 13, 2020

		@@ -28,10 +28,7 @@ export default function shouldRenderBasedOnError<
		const currentFieldError = get(error, name);

fix/improve setError & clearError #1907

fix/improve setError & clearError #1907

Conversation

bluebill1049 commented Jun 18, 2020 • edited

setError

clearError

github-actions bot commented Jun 18, 2020 • edited

codesandbox-ci bot commented Jun 18, 2020 • edited

JeromeDeLeon commented Jun 19, 2020

bluebill1049 commented Jun 19, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JeromeDeLeon Jun 19, 2020 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

keiya01 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JeromeDeLeon commented Jun 19, 2020

bluebill1049 commented Jun 19, 2020

JeromeDeLeon commented Jun 19, 2020

keiya01 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bluebill1049 commented Jun 19, 2020

bluebill1049 commented Jun 19, 2020

2DSharp commented Jun 19, 2020

Choose a reason for hiding this comment

bluebill1049 commented Jun 18, 2020 •

edited

github-actions bot commented Jun 18, 2020 •

edited

codesandbox-ci bot commented Jun 18, 2020 •

edited

JeromeDeLeon Jun 19, 2020 •

edited