-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change module name to index and remove npmignore #1956
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 41205fd:
|
Size Change: +9.12 kB (11%) Total Size: 78.6 kB
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a question. Thank you.
"main": "dist/index.js", | ||
"main:ie": "dist/index.ie11.js", | ||
"umd:main": "dist/index.umd.js", | ||
"unpkg": "dist/index.umd.min.js", | ||
"module": "dist/index.esm.js", | ||
"module:min": "dist/index.min.esm.js", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are main:ie
and umd:main
and so on used in only rollup config?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, is there any issues?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are no issues. I just wanted to hear the reason :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
main:ie
is for IE users, umd for users who use umd
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exactly, I wanted to confirm while these variables are used only in the config or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I noticed that https://react-hook-form.com/faqs#BrowserSupport still points to the old path. Should this be |
send a PR please @ryansully |
No description provided.