Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change module name to index and remove npmignore #1956

Merged
merged 6 commits into from
Jun 26, 2020

Conversation

bluebill1049
Copy link
Member

No description provided.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 25, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 41205fd:

Sandbox Source
winter-star-vqwdo Configuration

@github-actions
Copy link
Contributor

github-actions bot commented Jun 25, 2020

Size Change: +9.12 kB (11%) ⚠️

Total Size: 78.6 kB

Filename Size Change
dist/react-hook-form.es.js 0 B -14.1 kB (0%)
dist/react-hook-form.ie11.js 0 B -17.9 kB (0%)
dist/react-hook-form.js 0 B -14.1 kB (0%)
dist/react-hook-form.min.es.js 0 B -9.03 kB (0%)
dist/react-hook-form.umd.js 0 B -14.3 kB (0%)
dist/index.esm.js 14.1 kB +14.1 kB (100%) 🆘
dist/index.ie11.js 17.9 kB +17.9 kB (100%) 🆘
dist/index.js 14.1 kB +14.1 kB (100%) 🆘
dist/index.min.esm.js 9.03 kB +9.03 kB (100%) 🆘
dist/index.umd.js 14.3 kB +14.3 kB (100%) 🆘
dist/index.umd.min.js 9.12 kB +9.12 kB (100%) 🆘

compressed-size-action

Copy link
Contributor

@keiya01 keiya01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a question. Thank you.

Comment on lines +5 to +10
"main": "dist/index.js",
"main:ie": "dist/index.ie11.js",
"umd:main": "dist/index.umd.js",
"unpkg": "dist/index.umd.min.js",
"module": "dist/index.esm.js",
"module:min": "dist/index.min.esm.js",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are main:ie and umd:main and so on used in only rollup config?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, is there any issues?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are no issues. I just wanted to hear the reason :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

main:ie is for IE users, umd for users who use umd.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly, I wanted to confirm while these variables are used only in the config or not.

Copy link
Contributor

@keiya01 keiya01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bluebill1049 bluebill1049 merged commit a00cda2 into master Jun 26, 2020
@bluebill1049 bluebill1049 deleted the feature/improve-build branch June 26, 2020 22:23
@ryansully
Copy link

I noticed that https://react-hook-form.com/faqs#BrowserSupport still points to the old path. Should this be import { useForm } from 'react-hook-form/dist/index.ie11' instead?

@ryansully ryansully mentioned this pull request Jul 4, 2020
@bluebill1049
Copy link
Member Author

send a PR please @ryansully

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants