Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#231 improve dirty check #233

Merged
merged 29 commits into from
Aug 21, 2019
Merged

#231 improve dirty check #233

merged 29 commits into from
Aug 21, 2019

Conversation

bluebill1049
Copy link
Member

@bluebill1049 bluebill1049 commented Aug 20, 2019 •
edited

Fix isDirty issue: #231

stramel
stramel previously approved these changes Aug 20, 2019
View reviewed changes
@bluebill1049
Copy link
Member Author

This is PR still having issues, i am working on it.

@bluebill1049
Copy link
Member Author

@stramel I am removing those long console.warn they do end up in the final build, those words can't get uglified which result in the package size more than 5k (FYI) feel free to add them back once we have a good strategy to not include in the final build.

@bluebill1049 bluebill1049 merged commit ebdc830 into master Aug 21, 2019
@bluebill1049 bluebill1049 deleted the feature/enhanced-dirty branch August 21, 2019 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stramel stramel stramel left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bluebill1049 @stramel