Convert form state to use state #2600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the net size dropped 300KB across all bundles and functionality is essentially the same. I'm good with this as long as the checks are all passing. I don't see any reason that this should be an issue. |
stramel
previously approved these changes
Aug 18, 2020
It's actually dropped by refactoring two data types, but yeah thanks for the review @stramel 👍 |
* Update Yarn Lock and improve cypress tests * Undo some fixes
|
fixed @pmaier983 |
pmaier983
previously approved these changes
Aug 19, 2020
you too :) |
pmaier983
reviewed
Aug 20, 2020
cypress/integration/controller.ts
Outdated
| }); | ||
|
|
||
| // it('should validate the form with onChange mode and reset the form', () => { | ||
| // cy.visit('http://localhost:3000/controller/onChange'); | ||
| it('should validate the form with onChange mode and reset the form', () => { |
There was a problem hiding this comment.
Thank you for fixing! I wonder why it was broken in the first place!
|
plan to merge it this Friday 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 Summary
useRefstate touseStateerrorsobject insideformStateand keeperrorsat the root level as an aliasvalidatedFields&fieldsWithvalidationto Object type🐞 Bugs
let me know if you have any questions or concerns.