Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3296 - Log warning if conflicting keyName is used #3299

Merged
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
34 changes: 34 additions & 0 deletions src/useFieldArray.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -202,6 +202,40 @@ describe('useFieldArray', () => {
expect(console.warn).not.toBeCalled();
});

it('should output error message when a conflicting fieldArray keyName is found in the fieldValues in development mode', () => {
jest.spyOn(console, 'warn').mockImplementation(() => {});

process.env.NODE_ENV = 'development';

renderHook(() => {
const { control } = useForm({
defaultValues: {
test: [{ id: '123' }],
},
});
useFieldArray({ control, name: 'test' });
});

expect(console.warn).toBeCalledTimes(1);
});

it('should not output error message when a conflicting fieldArray keyName is found in the fieldValues in production mode', () => {
jest.spyOn(console, 'warn').mockImplementation(() => {});

process.env.NODE_ENV = 'production';

renderHook(() => {
const { control } = useForm({
defaultValues: {
test: [{ id: '123' }],
},
});
useFieldArray({ control, name: 'test' });
});

expect(console.warn).toBeCalledTimes(0);
});

it('should throw custom error when control is not defined in development mode', () => {
process.env.NODE_ENV = 'development';

Expand Down
25 changes: 20 additions & 5 deletions src/useFieldArray.ts
Original file line number Diff line number Diff line change
Expand Up @@ -33,11 +33,26 @@ const mapIds = <
>(
values: Partial<TFieldArrayValues>[] = [],
keyName: TKeyName,
): Partial<ArrayField<TFieldArrayValues, TKeyName>>[] =>
values.map((value: Partial<TFieldArrayValues>) => ({
[keyName]: generateId(),
...value,
}));
): Partial<ArrayField<TFieldArrayValues, TKeyName>>[] => {
let reservedKeyUsed = false;
const result = values.map((value: Partial<TFieldArrayValues>) => {
if (keyName in value) {
reservedKeyUsed = true;
}
return {
[keyName]: generateId(),
...value,
};
});

if (process.env.NODE_ENV !== 'production' && reservedKeyUsed) {
console.warn(
`📋 useFieldArray fieldValues contain the keyName \`${keyName}\` which is reserved for use by useFieldArray. https://react-hook-form.com/api#useFieldArray`,
);
}

return result;
};
milo- marked this conversation as resolved.
Show resolved Hide resolved

export const useFieldArray = <
TFieldArrayValues extends FieldValues = FieldValues,
Expand Down