Fix react native TS types for register - related to #369

[barrymay]

As a follow-up to my investigation on #369, I don't see a problem using react-native import-wise with react-native. In terms of the actual implementation, it's only using types from react-native, not any implementation.

That said, in doing a local test, I did see a case where using react-native type elements in TS causes a problem, because react-native's elements don't support a name property. (I tried following the demo from https://react-hook-form.com in TS and ran into this case)

So I added an extra name property model to the register call

• Allows passing in a ref that has no name, but allows the name to be specified in the register call
• In the same, way, allows a register call to be called outside of JSX with the name properly specified on the separate object properly

Here's an example of usage with the method - the other model using jsx is equivalent to what's on on react-hook-form.com

const testRef = useRef(null);
useEffect(() => {
 register(test2Ref.current, { name: "foo2" });
}, []);

...

return (
      <TextInput
        ref={testRef}
        onChangeText={text => setValue("foo", text)}
      />
);

(technically, it may be possible to get rid of the ref here altogether since we're manually setting the value in the onChangeText call, but it appears sufficient for now)

@bluebill1049 @stramel feel free to give any feedback!

[bluebill1049]

maybe it's worth to turn { name: string } into a type?

[barrymay]

fair and done (albeit maybe a bit overdone, I won't fight it :) )

[bluebill1049]

I think we only support

register({ name: 'xxx' }, { required: true })

is this try to support

register({ name: 'xxx', required: true })

[barrymay]

exactly - because when you pass in a ref to register from react native, that ref will not have a name on it (because react-native doesn't support the name property on those text elements)

[bluebill1049]

sounds good 👍 I guess we can do the same for the web as well

[barrymay]

yes - with this exact change (and I noted it in the comment) if you put the name in the second argument, it will override the name put on the element. You likely wouldn't do it, but it maybe helpful in a rare case.

[bluebill1049]

thanks very much @barrymay for investigating on this issue :)

[bluebill1049]

@barrymay merge whenever you are ready :)