Don't expose internal errors reference in handleSubmit #7718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiii
force-pushed
the
dont-expose-internal-state-in-handleSubmit-onInvalid
branch
3 times, most recently
from
0b278d5
to
2ec55c6
Compare
tiii
force-pushed
the
dont-expose-internal-state-in-handleSubmit-onInvalid
branch
from
2ec55c6
to
6006c2f
Compare
|
thank you again for your contribution. |
bluebill1049
approved these changes
Feb 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7717
_formState.errorsare cloned before passing them on toonInvalidhandler.This requires a change in the
cloneObjectmethod:On the web context we have lots of references on a
HTMLElementwhich would already slow the method down. On top of that, aHTMLInputElementhas a reference to the form, which itself references it's inputs again, causing an infinite loop.Because of that we now ignore
HTMLElements on the web and accordinglyComponents when usingreact-nativeand instead pass those on without cloning.