New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V8: feature: useFieldArray rules props #8102
Conversation
Size Change: +404 B (+2%) Total Size: 17.7 kB
|
This reverts commit d1c3bf7.
OMG, is it React 18 time already?! |
yes, @Moshyfawn looks pretty good. only one test failed with automation, I will look into it. |
fixed only a rendering count correcton |
Shouldn't we update the |
yea, I want to do a quick test here before merging into react 18. feel free to commit to that branch if you want to :) it's safe now. |
Sry, got sidetracked with work. Will review as soon as I wake up |
I am going to merge this PR first, @Moshyfawn you can leave feedback here and I will address them. 🙏 No pressure on the review too, we have real work as first priority to make a living ❤️ have a good weekend buddy ✌🏻 |
Thanks for understanding, @bluebill1049! ❤️ Had to compromise this week, as there're a bunch of releases I have to prepare for. Have a nice weekend, man! 🎊 |
* useFieldArray rules prop * remove required prop * combine logic within validateField * remove logic * update unset method to support root node in array * update api extrator * update type * update useEffect validation logic * update api extrator * fix submit field array error * extract logic into its own function for update root error object * 8.0.0-alpha.3 * update with unit tests coverage for rules validate, minLength and maxLength * include support for required prop for consitent API and test coverage * update API * save some bytes * upgrade to react 18 * Revert "upgrade to react 18" This reverts commit d1c3bf7. * update react * fix cypress test * remove render count * udpate package and include test coverage for nested field array * fix unit and cypress tests * update lock file * revert package * avoid react native breaking change and fix test
* V8: feature: useFieldArray rules props (#8102) * useFieldArray rules prop * remove required prop * combine logic within validateField * remove logic * update unset method to support root node in array * update api extrator * update type * update useEffect validation logic * update api extrator * fix submit field array error * extract logic into its own function for update root error object * 8.0.0-alpha.3 * update with unit tests coverage for rules validate, minLength and maxLength * include support for required prop for consitent API and test coverage * update API * save some bytes * upgrade to react 18 * Revert "upgrade to react 18" This reverts commit d1c3bf7. * update react * fix cypress test * remove render count * udpate package and include test coverage for nested field array * fix unit and cypress tests * update lock file * revert package * avoid react native breaking change and fix test * fix test and type error * 🚔 close #8653 when useFormContext provide no generic for type check (#8654) * close #8653 when useFormContext provide no generic for type check * update api contract * 🛰 useFormContext include type tests (#8656) * Revert "🚔 close #8653 when useFormContext provide no generic for type check (#8654)" This reverts commit 2e0c3f8. * Revert "🛰 useFormContext include type tests (#8656)" This reverts commit 34af5b3. * 🥼 update changelog related to #8653 * 7.34.0-next.0 * check validation required for field array if not array or empty length * include unit tests coverage for validate fields for array fields * update api extrator
close: #6879
ref: https://codesandbox.io/s/react-hook-form-usefieldarray-forked-iyejbp?file=/src/src/logic/createFormControl.ts
cc @Moshyfawn