assignId: Assign non-object values to value property #940
Conversation
…ues, assign other values (e.g. strings, arrays) to value property
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d1173a9:
|
src/logic/mapIds.ts
Outdated
| @@ -9,7 +10,7 @@ export const appendId = < | |||
| >( | |||
| value: FormArrayValues, | |||
| ) => ({ | |||
| ...value, | |||
| ...(isObject(value) ? { ...value } : { value }), | |||
There was a problem hiding this comment.
i guess this will still return
{
id: 'xxx',
value: 'xxx'
}
you cool with that?
There was a problem hiding this comment.
Yep! It keeps the shape consistent for non-object values, which is perfectly acceptable to me.
There was a problem hiding this comment.
the improvement is you can do append('test') instead of append({ value: 'test' }), also hard code the data as value probably not the best thing as well.
There was a problem hiding this comment.
i guess documentation probably can help on this.
There was a problem hiding this comment.
The issue is not with append, it's with setting defaultValues. Currently, string values get spread, which creates a crazy looking object like:
{
"0": "a",
"1": "b",
"2": "c",
"3": ".",
"4": "c",
"5": "o",
"6": "m",
"id": "5f0137bf-e201-425e-a7b0-f6cf76e0b3ca"
}
Co-Authored-By: Bill <bluebill1049@hotmail.com>
Possible solution to #924.