fix(yupResolver): Yup fails silently (#328) (#320)

react-hook-form · Jan 18, 2022 · 0f016f4 · 0f016f4
1 parent ce79a77
commit 0f016f4
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 1 deletion.
diff --git a/jest.config.js b/jest.config.js
@@ -3,6 +3,7 @@ module.exports = {
   restoreMocks: true,
   testMatch: ['**/__tests__/**/*.+(js|jsx|ts|tsx)'],
   transformIgnorePatterns: ['[/\\\\]node_modules[/\\\\].+\\.(js|jsx)$'],
+  testPathIgnorePatterns: ['/__fixtures__/', '/\\.'],
   moduleNameMapper: {
     '^@hookform/resolvers$': '<rootDir>/src',
   },

diff --git a/yup/src/__tests__/yup.ts b/yup/src/__tests__/yup.ts
@@ -290,4 +290,22 @@ describe('validateWithSchema', () => {
       errors: { name: { message: 'Email or name are required', type: 'name' } },
     });
   });
+
+  it('should throw an error without inner property', (done) => {
+    const schemaWithWhen = yup.object({
+      name: yup.string().required(),
+      value: yup.string().when('name', {
+        is: 'test',
+        then: yup.number().required(),
+      }),
+    });
+
+    // @ts-expect-error
+    yupResolver(schemaWithWhen)({ name: 'test', value: '' }).catch((e) => {
+      expect(e).toMatchInlineSnapshot(
+        `[TypeError: You cannot \`concat()\` schema's of different types: string and number]`,
+      );
+      done();
+    });
+  });
 });
diff --git a/yup/src/yup.ts b/yup/src/yup.ts
@@ -82,7 +82,11 @@ export const yupResolver = <TFieldValues extends FieldValues>(
       }),
       errors: {},
     };
-  } catch (e) {
+  } catch (e: any) {
+    if (!e.inner) {
+      throw e;
+    }
+
     const parsedErrors = parseErrorSchema(e, validateAllFieldCriteria);
     return {
       values: {},