Fix resolvers typings with react-hook-form@7.15.0

[julienfouilhe]

I upgraded to the latest react-hook-form and @hookform/resolvers versions and all of a sudden all my forms that were using the yupResolver were throwing a typescript error while those using the io-ts resolver (I'm progressively migrating to io-ts) didn't.

I checked what could be the source and figured the typings were not infered properly when wrapping the generic function.

Example of something that does not work:

const { register } = useForm<Type>({
  resolver: yupResolver(schema),
});

Fixes #234

[bluebill1049]

thanks for the contribution 💪

[alb7h]

@bluebill1049 Any idea when this'll get merged?

[bluebill1049]

let's wait for @jorisre he is the master mind behind resolver.

[julienfouilhe]

@bluebill1049 Any idea when @jorisre will be available to review this? Upgrading to the latest version of react-hook-form is impossible because of this issue.

[bluebill1049]

Hey @julienfouilhe I will review it now, and I have also pinged Joris too.

[bluebill1049]

👍

[bluebill1049]

wondering why have to start casting now.

[julienfouilhe]

I don't know exactly but seems like an empty object is not assignable to the DeepMap with the new version of FieldErrors from react-hook-form?

[bluebill1049]

LGTM.

[jorisre]

Sorry for the delay. I'll look at it tonight

[bluebill1049]

Sorry for the delay. I'll look at it tonight

Merci

[jorisre]

We loose the return type for the resolvers:

We are getting

{
    [x: string]: any;
}

instead of the values. That why the resolvers types is a bit different

[julienfouilhe]

@jorisre What would be the expected signature? I feel like values should always be typed unknown, and we should infer the TFieldValues from the schema, like this:

import { ResolverResult, ResolverOptions, FieldValues } from 'react-hook-form';
import { z } from 'zod';

export type Resolver = <TFieldValues extends FieldValues, TContext>(
  schema: z.Schema<TFieldValues, any>,
  schemaOptions?: Partial<z.ParseParamsNoData>,
  factoryOptions?: { mode?: 'async' | 'sync' },
) => (
  values: unknown,
  context: TContext | undefined,
  options: ResolverOptions<TFieldValues>,
) => Promise<ResolverResult<TFieldValues>>;

This would actually allow not to specify the FieldValues to useForm since it is automatically infered from the zod schema:

useForm({
  resolver: zodResolver(schema),
})

[jorisre]

Thank you for the contribution @julienfouilhe !

LGTM! I'll make some minor changes in another PR.

Sorry again for the delay.

[julienfouilhe]

@jorisre I fixed the tests sorry about that. Thought I had run them.

I had to add unpacking NestedValue support to io-ts

[github-actions]

🎉 This PR is included in version 2.8.1 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[bluebill1049]

thank you @julienfouilhe & @jorisre ❤️