Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(ajvResolver): reduce bundle size #523

Merged
merged 1 commit into from Mar 17, 2023
Merged

Conversation

jorisre
Copy link
Member

@jorisre jorisre commented Mar 17, 2023

No description provided.

@github-actions
Copy link
Contributor

Size Change: -109 kB (-84%) 🏆

Total Size: 20.4 kB

Filename Size Change
ajv/dist/ajv.js 638 B -36.4 kB (-98%) 🏆
ajv/dist/ajv.module.js 597 B -36.5 kB (-98%) 🏆
ajv/dist/ajv.umd.js 751 B -36.4 kB (-98%) 🏆
ℹ️ View Unchanged
Filename Size
class-validator/dist/class-validator.js 518 B
class-validator/dist/class-validator.module.js 541 B
class-validator/dist/class-validator.umd.js 621 B
computed-types/dist/computed-types.js 359 B
computed-types/dist/computed-types.module.js 376 B
computed-types/dist/computed-types.umd.js 456 B
dist/resolvers.js 359 B
dist/resolvers.module.js 373 B
dist/resolvers.umd.js 454 B
io-ts/dist/io-ts.js 1.28 kB
io-ts/dist/io-ts.module.js 1.18 kB
io-ts/dist/io-ts.umd.js 1.41 kB
joi/dist/joi.js 592 B
joi/dist/joi.module.js 610 B
joi/dist/joi.umd.js 698 B
nope/dist/nope.js 345 B
nope/dist/nope.module.js 365 B
nope/dist/nope.umd.js 434 B
superstruct/dist/superstruct.js 302 B
superstruct/dist/superstruct.module.js 319 B
superstruct/dist/superstruct.umd.js 404 B
typanion/dist/typanion.js 323 B
typanion/dist/typanion.module.js 336 B
typanion/dist/typanion.umd.js 418 B
vest/dist/vest.js 472 B
vest/dist/vest.module.js 436 B
vest/dist/vest.umd.js 562 B
yup/dist/yup.js 629 B
yup/dist/yup.module.js 643 B
yup/dist/yup.umd.js 732 B
zod/dist/zod.js 572 B
zod/dist/zod.module.js 591 B
zod/dist/zod.umd.js 679 B

compressed-size-action

Copy link
Member

@bluebill1049 bluebill1049 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ooh wow almost 100% save, awesome!

@bluebill1049 bluebill1049 merged commit fc00379 into master Mar 17, 2023
3 checks passed
@bluebill1049 bluebill1049 deleted the perf/reduce-package-size branch March 17, 2023 21:07
@ilteoood
Copy link

@bluebill1049 this is a breaking change that should be mentioned in the changelog

@jorisre
Copy link
Member Author

jorisre commented Mar 24, 2023

@ilteoood Can you elaborate? There is no breaking changes here. It's mentioned in the release note

image

@ilteoood
Copy link

ilteoood commented Mar 24, 2023

@jorisre

IMO this should be listed in the breaking changes, as it requires some actions to be done on the user side in order to upgrade smoothly.

If it was just a "performance improvement", I should be able to upgrade without doing any action, right? But this seems not to be the case, since now I need to include both ajv and ajv-errors as dependencies in my project.

@jorisre
Copy link
Member Author

jorisre commented Mar 24, 2023

Alright, I'll update the release notes. Just wanted to clarify that ajv and ajv-errors were not intended to be bundled by resolvers; it was a misconception from the start. On the bright side, this means you're free to use the specific versions of ajv and ajv-errors that you prefer!

@ilteoood
Copy link

@jorisre you are completely right, but as this has been changed it should be explicitly written in the changelog.

Just to warn the user that he should take care of this starting now 😄

@jorisre
Copy link
Member Author

jorisre commented Mar 24, 2023

Done ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants