Fix schema type error mentioned in issue 549

[henrikvolmer]

Fixes issue #549

[bluebill1049]

Any chance you could add some test coverage on the fix? thank 🙏

[henrikvolmer]

Do you have any suggestions, how to test a typescript type change? In my opinion, typescript will test it automatically on compile time.

[bluebill1049]

If you can include usage in the test case would be good, that proof why the issue was there in the first place.

[henrikvolmer]

I changed some more, to improve/fix the type inference for useForm. Now the generic in useForm is unnecessary because it'll be inferred from the schema.

[henrikvolmer]

Any news here? Do you need something?

[jorisre]

LGTM! thanks for the contribution

[github-actions]

🎉 This PR is included in version 3.1.1 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[henrikvolmer]

@jorisre @bluebill1049 : I think this should have been better at least a minor release, since the type was any before and is now specialized. This is probably why some users have a problem with their types. Because of any the type check was disabled before and therefore wrong types didn't cause an error.

[bluebill1049]

Thanks @henrikvolmer for supporting on this issue. Yes, I think a minor version would probably be the wiser release.

[henrikvolmer]

@bluebill1049 : So how we move on? Can you change the patch version to a minor version?

[bluebill1049]

It's a little bit of a difficult situation here We can't overwrite the release or re-release. perhaps @jorisre maybe we just added to the release note on this change which may cause breaking changes to existing apps.

[jorisre]

We can:

• Update the release note
• Re-release a minor version with a release note

@bluebill1049 What do you prefer?

[bluebill1049]

I think we just update the release note would be the better choice, cause the patch is already release. thanks @jorisre 🙏

[jorisre]

Done https://github.com/react-hook-form/resolvers/releases/tag/v3.1.1