Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add deps argument for useConditionalUpdateEffect and useConditionalEffect hooks #201

Merged
merged 1 commit into from
Jul 16, 2021
Merged

Add deps argument for useConditionalUpdateEffect and useConditionalEffect hooks #201

merged 1 commit into from
Jul 16, 2021

Conversation

xobotyi
Copy link
Contributor

@xobotyi xobotyi commented Jul 11, 2021

What new hook does?

Add deps argument for useConditionalUpdateEffect and useConditionalEffect hooks

BREAKING CHANGE: useConditionalUpdateEffect and useConditionalEffect now has changed call signature (new argument).

Checklist

@xobotyi xobotyi added the ✨ enhancement New feature or request label Jul 11, 2021
@xobotyi xobotyi requested a review from JoeDuncko July 11, 2021 20:41
@xobotyi xobotyi force-pushed the fix-157 branch 4 times, most recently from 7f75f82 to bb69b12 Compare July 11, 2021 20:55
@codecov
Copy link

codecov bot commented Jul 11, 2021 •
edited
Loading

Codecov Report

Merging #201 (64409fc) into master (2f0f362) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #201   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           42        42           
  Lines          729       725    -4     
  Branches       128       125    -3     
=========================================
- Hits           729       725    -4
Impacted Files Coverage Δ
src/index.ts 100.00% <100.00%> (ø)
src/useConditionalEffect/useConditionalEffect.ts 100.00% <100.00%> (ø)
...ditionalUpdateEffect/useConditionalUpdateEffect.ts 100.00% <100.00%> (ø)
src/util/const.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f0f362...64409fc. Read the comment docs.

@JoeDuncko
Copy link
Contributor

@xobotyi It looks like useConditionalUpdateEffect's docs haven't been updated to include deps - should we?

Also, it looks like there are a couple linting errors.

@xobotyi
feat: deps for useConditionalUpdateEffect and useConditionalEffect
64409fc 
Add new argument for above functions.

fix: 157

BREAKING CHANGE: `useConditionalUpdateEffect` and `useConditionalEffect`
now has changed call signature (new argument).
@xobotyi
Copy link
Contributor Author

xobotyi commented Jul 16, 2021

@JoeDuncko just thought to poke you in discord, about this PR =)

Both fixed.

JoeDuncko
JoeDuncko approved these changes Jul 16, 2021
View reviewed changes
Copy link
Contributor

@JoeDuncko JoeDuncko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'm not sure how to trigger the breaking change version bump, so I'll leave merging to you @xobotyi

@xobotyi
Copy link
Contributor Author

xobotyi commented Jul 16, 2021

@JoeDuncko it is triggered automatically if any of commits has BREAKING CHANGE: ... in commit message

@xobotyi xobotyi merged commit bd56af3 into master Jul 16, 2021
@xobotyi xobotyi deleted the fix-157 branch July 16, 2021 13:20
github-actions bot pushed a commit that referenced this pull request Jul 16, 2021
@semantic-release-bot
chore(release): 4.0.0 [skip ci]
efe14d5 
# [4.0.0](v3.8.0...v4.0.0) (2021-07-16)

### Features

* deps for `useConditionalUpdateEffect` and `useConditionalEffect` ([#201](#201)) ([bd56af3](bd56af3))

### BREAKING CHANGES

* `useConditionalUpdateEffect` and `useConditionalEffect`
now has changed call signature (new argument).
@xobotyi
Copy link
Contributor Author

xobotyi commented Jul 16, 2021

🎉 This PR is included in version 4.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoeDuncko JoeDuncko JoeDuncko approved these changes

Assignees
No one assigned
Labels
✨ enhancement New feature or request released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xobotyi @JoeDuncko