Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Heroicons 2 #590

Merged
merged 3 commits into from Aug 30, 2022
Merged

Add Heroicons 2 #590

merged 3 commits into from Aug 30, 2022

Conversation

bacali95
Copy link
Contributor

@bacali95 bacali95 commented Aug 29, 2022 •
edited

This MR adds support for HeroIcons version 2.0.8, @nolanleung can you please take a look? thanks 馃槃

nolanleung
nolanleung approved these changes Aug 30, 2022
View reviewed changes
Copy link
Collaborator

@nolanleung nolanleung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome!

@nolanleung nolanleung merged commit 85bea64 into react-icons:master Aug 30, 2022
@bacali95 bacali95 deleted the feat/add-heroicons-2 branch August 30, 2022 04:56
@rkjain119 rkjain119 mentioned this pull request Sep 3, 2022
Closed
@corysimmons
Copy link

@bacali95 @nolanleung Does this include the mini sizes?

@bacali95
Copy link
Contributor Author

@bacali95 @nolanleung Does this include the mini sizes?

No it doesn't, since the mini icons are the same solid ones but smaller I thought maybe using the size prop wee can achieve the same result

@corysimmons
Copy link

It doesn't look like they're identical-identical. Notice the top of the box not being rounded anymore.

Solid (24x24):
image

Mini (20x20):
image

I think the imports should be:

  • import {Hi2Xyz} from 'react-icons/hi2/outline
  • import {Hi2Xyz} from 'react-icons/hi2/solid
  • import {Hi2Xyz} from 'react-icons/hi2/mini

@bacali95
Copy link
Contributor Author

That is indeed correct, they don't look the same, I will open a PR later on to add the mini imports..

@bacali95 bacali95 mentioned this pull request Sep 13, 2022
Closed
alisamar added a commit to alisamar/react-icons that referenced this pull request Sep 19, 2022
@alisamar
Merge branch 'master' of github.com:alisamar/react-icons
42bc60a 
* 'master' of github.com:alisamar/react-icons:
  v4.5.1
  Add Heroicons 2 (react-icons#590)
@Cody-W-Tucker
Copy link

Cody-W-Tucker commented Sep 26, 2022 •
edited

I keep getting an import error, has something changed?

Module not found: Can't resolve 'react-icons/hi2'
  4 | import { HiHome, HiOutlineCurrencyDollar, HiX } from 'react-icons/hi'
> 5 | import { HiBars3, HiXMark } from 'react-icons/hi2'

@corysimmons
Copy link

@Cody-W-Tucker It hasn't been published to npm yet.

@kamijin-fanta kamijin-fanta mentioned this pull request Oct 22, 2022
Open
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nolanleung nolanleung nolanleung approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bacali95 @corysimmons @Cody-W-Tucker @nolanleung