Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding support for material design symbols #619

Merged
merged 3 commits into from
May 31, 2023
Merged

adding support for material design symbols #619

merged 3 commits into from
May 31, 2023

Conversation

nicksrandall
Copy link
Contributor

@nicksrandall nicksrandall commented Oct 11, 2022 •
edited
Loading

In April 2022, Google released a new version of "material design icons" called "material design symbols" which come in 3 variants (Sharp, Rounded, and Outlined). This PR adds support for this new set of icons.

Note: This change also bumps Material Icons package to latest version.

Also, not 100% sure but this might superseed #408

@nicksrandall
Copy link
Contributor Author

@kamijin-fanta anything else I can do to make this PR easy to merge?
Thanks for all you do!

@kamijin-fanta kamijin-fanta added the icons/add Add new icon label Oct 26, 2022
@nicksrandall
Copy link
Contributor Author

@kamijin-fanta I have rebased this PR to work with all your latest changes. I think it is ready to go.

@nicksrandall
Copy link
Contributor Author

nicksrandall commented Nov 29, 2022 •
edited
Loading

@kamijin-fanta This has been rebased again and bumped to the latest version of Material Design Icons. It should be ready to go.

@nicksrandall nicksrandall mentioned this pull request Nov 29, 2022
Closed
@user72356
Copy link

This is a very nice PR and I'm disappointed it's being ignored.

@nicksrandall
Copy link
Contributor Author

@kamijin-fanta anything I can do to assist this in getting reviewed and/or merged? Do you have any concerns with this implementation?

@nicksrandall
Copy link
Contributor Author

@kamijin-fanta Any chance this can be merged?

@nicksrandall
Copy link
Contributor Author

I have fixed the merge conflicts. I would really like to see this land.

@mike-shtil
Copy link

@kamijin-fanta this very useful PR seems to have been ignored for many months now. Is there anything the community here can do to help with the review?

@mike-shtil mike-shtil mentioned this pull request Apr 23, 2023
Open
@bring-shrubbery
Copy link

@kamijin-fanta We need this very much. Is there any way we can make it easier to merge this PR?

@mike-shtil

This comment was marked as off-topic.

Sign in to view
@yuki16bit
Copy link

The merge of this PR would be very nice and very useful to our team (a lot of UI / UX designers were already migrated to "Symbols" now), I wonder why this PR is being ignored for so long?

@nolanleung nolanleung added this pull request to the merge queue May 31, 2023
Merged via the queue into react-icons:master with commit 99c0213 May 31, 2023
@nolanleung
Copy link
Collaborator

🚀

@user72356
Copy link

@nolanleung Awesome news, thank you so much! Can we expect an NPM release soon?

I need this right now so I've built it myself from the source. I'm not sure which file to use: "react-icons-4.8.1-snapshot.2.tgz" or "react-icons-all-files-4.8.1-snapshot.2.tgz"?

"all-files" is slightly larger than the other one...

@kamijin-fanta
Copy link
Member

This commit may have significantly increased build time. There is also the possibility of revert.

kamijin-fanta added a commit that referenced this pull request Jun 2, 2023
@kamijin-fanta
Revert "adding support for material design symbols (#619)"
b618eb7 
This reverts commit 99c0213.
@kamijin-fanta kamijin-fanta mentioned this pull request Jun 2, 2023
Open
@kamijin-fanta
Copy link
Member

Different alternative methods of implementation were used. I want you to try it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nolanleung nolanleung nolanleung approved these changes

Assignees
No one assigned
Labels
icons/add Add new icon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@nicksrandall @user72356 @mike-shtil @bring-shrubbery @yuki16bit @nolanleung @kamijin-fanta