Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support className passthrough #152

Closed
32 of 34 tasks
yanickrochon opened this issue Sep 26, 2016 · 2 comments
Closed
32 of 34 tasks

Support className passthrough #152

yanickrochon opened this issue Sep 26, 2016 · 2 comments
Assignees

Comments

@yanickrochon
Copy link
Contributor

yanickrochon commented Sep 26, 2016

User code should be able to set extra className values to just about any component.

  • Button
  • Breadcrumb should set to the nav element
  • Card
  • CardPanel
  • CardTitle should set to the top level div element
  • Chip should set to the top level div element
  • Col
  • Collapsible
  • CollapsibleItem should set to the li element
  • Collection should set to the list (i.e. ul / div) element
  • CollectionItem
  • Dropdown should set on the span (top level) element
  • Footer
  • Icon should set on the i element
  • Input should set to the input / textarea / select element
  • MediaBox should set on the img element
  • MenuItem
  • Modal should set to the div (top level) element
  • NavItem should set to the li element
  • Navbar
  • Pagination
  • PaginationButton
  • Preloader should set to the div (top level) element
  • ProgressBar
  • Row
  • SearchForm should set to the form (top level) element
  • SideNav should set to the nav (top level) element
  • Slide
  • Spinner should set to the div (top level) element
  • Tab should set to the top level element (not implemented component)
  • Table
  • Tabs
  • Tag should pass to the Chip component
  • Toast should set to the button element

*Overlay and OverlayTrigger are special cases... no?

@alextrastero
Copy link
Member

Yes indeed @yanickrochon, I'm currently working on basic specs for each component, I'm also fixing the 0.15 warnings and I will also pass className props to the above mentioned, thanks for this!

@alextrastero
Copy link
Member

Fixed in 2.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants