This repository has been archived by the owner on Apr 27, 2022. It is now read-only.
Library re-architecture #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added RNAdMobFullScreenAdModule abstract class and refactored Ads to extend the class.
Changed App Open Ads to have requestId, to make it compatible with other full screen ads.
Added useFullScreenAd.ts and reuse hooks codes
Now useAppOpenAd hook must be called inside component wrapped with AppOpenAdProvider. Before this change, AppOpenAd was re-created if more than one hook is generated. To fix this, we must wrap components with context and provide sigleton ad instance.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-architecture both native side code and typescript side code and added detailed example usage to example app.
Also this PR fixes several issues:
#29 #30 #32 #33 #37