Implement basic support for adding maps to SCNMaterial #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnjm
changed the title
macrozone
reviewed
Dec 6, 2017
| @@ -69,20 +69,19 @@ export default (mountConfig, propTypes = {}, nonUpdateablePropKeys = []) => { | |||
| // any custom props (material, shape, ...) | |||
| const nonNodePropKeys = keys(propTypes); | |||
|
|
|||
| const processColors = props => ({ | |||
| const parseMaterials = props => ({ | |||
There was a problem hiding this comment.
there is a file called "parseMaterial", but exported functions have completly different names.
But here you have function "parseMaterials". I know it was already confusing to begin with, but maybe we can improve here
There was a problem hiding this comment.
I renamed it to processMaterial to match the processColor function we are already using
components/lib/parseMaterial.js
Outdated
| }, | ||
| }), | ||
| material, | ||
| ); |
There was a problem hiding this comment.
- it took my a while to get that. Can you rename the variables? Also maybe an approach without reduce would be more easy to understand. maybe with mapValues from lodash?
- also a comment about why we support diffuse to be a string.
- instead of typeof you can use
isString(prevMaterial[property])
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows for materials to set with maps like-