Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Android): Find react-native using node module resolution #481

Merged
merged 1 commit into from
Nov 2, 2020

Conversation

tido64
Copy link
Member

@tido64 tido64 commented Oct 31, 2020

Summary:

AsyncStorage assumes that it is installed in node_modules in the parent folder. This may not always be the case.

Test Plan:

Android CI should pass.

@tido64 tido64 requested a review from krizzu October 31, 2020 19:26
Copy link
Member

@krizzu krizzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coolio 💪

@tido64 tido64 merged commit 7814ae3 into master Nov 2, 2020
@tido64 tido64 deleted the tido/fix-resolve-rn branch November 2, 2020 20:59
@krizzu
Copy link
Member

krizzu commented Nov 2, 2020

🎉 This PR is included in version 1.13.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@krizzu krizzu added the released label Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants