Add Windows AsyncStorage

[kaiguo]

Summary:

Add Windows AsyncStorage.
Closes microsoft/react-native-windows#2271.

Test Plan:

0. System requirments.
1. Run yarn start:windows.
2. Open example/windows/AsyncStorageExample.sln with VisualStudio and run.

[kaiguo]

@krizzu there are bunch of Flow check errors inside react-native/Libraries from test pipeline, any idea how to address them?

https://circleci.com/gh/react-native-community/async-storage/2125?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link

[krizzu]

@kaiguo It's caused by bumping RN version, while Flow stays on the old one.
Is there a reason for changing it to 0.61? I haven't tested AsyncStorage with that version yet.

[kaiguo]

Is there a reason for changing it to 0.61? I haven't tested AsyncStorage with that version yet.

@krizzu react-native-windows has a peer dependency on RN 0.61.5. I guess I can revert it to 0.58 for now, the downside is windows sample won't compile/run😢.

[krizzu]

@krizzu react-native-windows has a peer dependency on RN 0.61.5. I guess I can revert it to 0.58 for now, the downside is windows sample won't compile/run😢.

I see. Well, we just need to make sure that AS works with 0.61.5 now.
For RN 0.61.5, try upgrading to Flow version 0.105.0. Here's a config used in RN 0.61.5 - I guess we just need to do some adjustments.

[kaiguo]

@krizzu flowconfig changes did fix the flow check errors, thanks! But looks like both iOS and Android builds are broken after upgrading to 61. I created a separate branch here which fixed Android and Flow issues. For iOS, I think we need to switch to pod linking, looks like that's the only supported way on 61+. I'm not very familiar with iOS so I created #328 to track the rest of the work.

I'll keep react-native on 59 in this PR for now.

[kaiguo]

PR that upgrades iOS and Android sample apps to RN 61: #329.

[krizzu]

@kaiguo Great, let's fix merge #328 first, so you can keep this PR with RN 61.

[krizzu]

@kaiguo Sorry for keeping you waiting, but I'm waiting for someone else to have a look here (with Windows experience, asked at RN channel).

[kaiguo]

@kaiguo Kai Guo FTE Sorry for keeping you waiting, but I'm waiting for someone else to have a look here (with Windows experience, asked at RN channel).

Sure, good to have some extra eyes on this : )

[empyrical]

Are there issues with the the newer version of RNCLI?

[kaiguo]

4.x has a peer dependency on RN 62, the test apps are on 61 so it generated bunch of warnings in yarn install. 3.x is probably a better match for RN 61.

[krizzu]

I think there's no need to prolong this PR. Thanks for all the work @kaiguo 💪 🎉

[kaiguo]

@krizzu thanks for merging this in.

I'm trying to use the module in another project and just noticed the changes haven't been published yet, do we know when the next release will be?

[krizzu]

@kaiguo I'm going to issue new release later today