Add flow annotation to index & hooks #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Including
react-native-community/async-storagein a new project with flow doesn't actually work due to the index file not having the flow annotation. (Blank project with[declarations] node_modules/**in the flowconfig, flow version 0.132.0)This change adds flow annotations. Runtime wise this is only a comment and thus can't break anything other than flow itself (which still works).
Test Plan:
yarn teststill works.I'm not completely familiar with how the build process works, but my understanding is that the .flow files in lib will be copied over as is. Thus, the output would look like this, and flow typing would now work:
If this looks good, I can also bump the version before merging if you'd like.