Fixing ios issues with basic/example #2775
Conversation
- upgraded dependencies especially react-native to support Xcode 11 (https://github.com/facebook/react-native/pull/25146/files) - texts of the top buttons are now readable - ios: added NSMicrophoneUsageDescription to info.plist
- updated to recommended Xcode project settings
Added a method to lock a capture device, apply settings via a block, and unlock the device again.
|
Thanks for this pull request @rfischer I reviewed again now some of your changes. You are upgrading https://github.com/facebook/react-native/pull/25146/files Which I already experienced and work on #2735 (comment) I need to test the changes on android, as I tried to upgrade the basic example myself in the previous weeks, but failed doing it.. I would still keep two separate pull request:
You can branch out of your second pull request and add those changes temporarely to test the basic example... That is how I am working now... until we have fully working development environment. It is easier to work with small pull request. Sorry for closing this before, I understand now that you are having some issues with the development environment, I have been trying to fix those issues in the past but then prioritized other tasks... Let me test this changes on Android, make some changes to this pull request and I will give you an update tonight. If you want to discuss or need help in chat, I am available full time to assist you Thanks a lot |
fabOnReact
changed the title
fabOnReact
changed the title
fabOnReact
changed the title
This reverts commit 6c5790c.
There was a problem hiding this comment.
I tested your changes on Android and everything works fine (even MLKIT features).
Really nice pull request, I hope we will merge also 2774 very soon.
Can you accept my changes published in pull request rfischer#2 ???
I tested using react-native version "0.59.9"
I just have one more doubt explained below.
I still need to test this branch on IOS.
Thanks a lot
I wish you a good weekend
Fabrizio
Revert "refactor(ios): lock and unlock device"
|
I tested the pull request on both iPhone and Android development environment. This pull request fixes the issues previously experienced in this comment #2735 (comment) so I believe it is a priority to merge it. Closes Feature Request #2736 by upgrading the react-native version for the basic example to version higher then I was able to install the project before and after deleting I will remove mlkit feature from the basic example in my next pull request. Thanks a lot @rfischer for fixing this, I tried to upgrade this example to 0.61.5 in the past.. but could not go through all the errors... This is really important pull request and was experienced from many users, I wish you best luck also for 2774. Just a notice, we did some Thanks a lot |
| @@ -5,7 +5,7 @@ | |||
| "@babel/runtime": "^7.1.2", | |||
| "babel": "^6.23.0", | |||
| "react": "16.8.3", | |||
| "react-native": "0.59.1" | |||
| "react-native": "^0.59.1" | |||
There was a problem hiding this comment.
@rfischer the same changes needs to be done for /examples/mlkit/package.json. I am working on it, let me know if you want to add it to this pull request.
There was a problem hiding this comment.
@fabriziobertoglio1987 I never tried the mlkit example so far. But if the same fix is also needed there, then you can add it to this pull request.
There was a problem hiding this comment.
fabOnReact@52ec1df otherwise I publish the pull request. You need to register in firebase and download the GoogleServices-Info.plist file, but don't mind this .. I will resolve this comment as soon as I publish the pull request.. Just a reminder that it has to be done. Thanks a lot
Summary
The basic example project wasn't working with the latest Xcode version. Therefore I made some changes:
Test Plan
I tested it by running the example ios project and checking whether changing the camera settings still works or not.
Compatibility