This repository has been archived by the owner on Jun 16, 2023. It is now read-only.
Use empty string for undefined cameraId #3117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MarcoScabbiolo sorry that I keep adding changes that just adds more stuff for the v4 migration, this should be the last one! But since we constantly use this library, these fixes are a must for us. |
6 tasks
MarcoScabbiolo
approved these changes
Feb 19, 2021
No problem, I'm keeping track of all the changes to make sure they land in v4 as well. Thanks for contributing. |
MateusAndrade
approved these changes
Feb 23, 2021
n1ru4l
pushed a commit
that referenced
this pull request
Feb 23, 2021
## [3.42.3](v3.42.2...v3.42.3) (2021-02-23) ### Bug Fixes * Use empty string for undefined cameraId ([#3117](#3117)) ([bed16e9](bed16e9))
|
🎉 This PR is included in version 3.42.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
sunil-dev7
added a commit
to sunil-dev7/react-native-camera
that referenced
this pull request
Jun 11, 2021
## [3.42.3](react-native-camera/react-native-camera@v3.42.2...v3.42.3) (2021-02-23) ### Bug Fixes * Use empty string for undefined cameraId ([#3117](react-native-camera/react-native-camera#3117)) ([bed16e9](react-native-camera/react-native-camera@bed16e9))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up from here (#3113) .
The reason the RNCamera component is always rendered twice (aka, a
defaultViewis created on the native side) is because ofRCT_CUSTOM_VIEW_PROPERTYcombined with a property that is set tonull. When this happens, RN creates a "fake" default view to store default props. Although this works fine most of the time, it creates some unnecessary classes and resources being kept in memory even after the camera unmounts.After digging a bit, the prop
cameraIdbeing null is the sole reason RN creates thisdefaultView. This PR uses an empty string as the "no value" value instead, removing the extra view creation.Note: The change is not breaking, anyone using
cameraId=nullwill continue to work as before. However, to prevent this extra view from being created, the prop must be set tocameraId=''instead.Lastly, this only shows how we must be careful with
nullproperties and resources acquired/released in the init/dealloc methods!