Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make react-native-windows an optional peerDependency #149

Merged
merged 1 commit into from
Feb 22, 2022
Merged

make react-native-windows an optional peerDependency #149

merged 1 commit into from
Feb 22, 2022

Conversation

bell-steven
Copy link
Contributor

@bell-steven bell-steven commented Nov 22, 2021

While installing this, I get this warning

npm WARN @react-native-community/checkbox@0.5.9 requires a peer of react-native-windows@>=0.62 but none is installed. You must install peer dependencies yourself.

Peer dependencies are automatically installed on npm v7+, which is probably not what we want for non react-native-windows users.

References:
This twitter thread
NPM dependency docs

@nicholaslee119
Copy link
Collaborator

Thanks for your PR, It would be released in the next version

@bell-steven
Copy link
Contributor Author

This may close #123

@pushpender-singh-ap
Copy link

@nicholaslee119 when do we get the next release?

@nicholaslee119 nicholaslee119 changed the base branch from master to develop February 22, 2022 10:08
@nicholaslee119 nicholaslee119 merged commit bfe43a4 into react-native-checkbox:develop Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants