fix(iOS): expose testID from wrapping view component.
#156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ox/develop release 0.5.10
Before this change, `testID` was exposed from the native sub component `IOSCheckBoxNativeComponent`. However, this component does not expose the accessibility info (`accessible`, `accessibilityRole`, etc.), which is exposed in the parent RN component `View`. Thus, retrieving this information on tests by the `testID` is not possible unless accessing the parent view.
asafkorem
force-pushed
the
feature/ios/move-props-to-parent-view
branch
from
70d5914
to
73bb351
Compare
|
@nicholaslee119 this is highly important change in order to properly end-to-end test this component (from Detox for example). Generally, the I would greatly appreciate if you can release a version soon with this fix 🙏🏼 |
|
@asafkorem thanks for your PR, it will be released in the next version. |
|
Thanks @nicholaslee119! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change,
testIDwas exposed from the native sub componentIOSCheckBoxNativeComponent.However, this component does not expose the accessibility info (
accessible,accessibilityRole, etc.), which is exposed in the parent RN componentView.Thus, retrieving this information on tests by the
testIDis not possible unless accessing the parent view.