feat: Expose hasString method for iOS 14+ #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ios/RNCClipboard.m
Outdated
| RCT_EXPORT_METHOD(hasString:(RCTPromiseResolveBlock)resolve | ||
| reject:(__unused RCTPromiseRejectBlock)reject) | ||
| { | ||
| bool stringPresent = false; |
There was a problem hiding this comment.
nit: BOOL should be preferred in ObjC, with YES or NO as values.
See https://stackoverflow.com/questions/541289/objective-c-bool-vs-bool
ios/RNCClipboard.m
Outdated
| stringPresent = clipboard.hasStrings; | ||
| } else { | ||
| NSString* stringInPasteboard = clipboard.string; | ||
| stringPresent = stringInPasteboard != nil; |
|
Awesome! Can we implement stuff from #64 also? |
Naturalclar
approved these changes
Oct 12, 2020
There was a problem hiding this comment.
@gnardini amazing! tested on example app and seems to be working great.
sorry for the example project on this repo not working for you, there was a typo in podfile which was preventing the example to work, but now it's fixed.
|
I'm finding that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firstly, thanks for the work on the clipboard!
Overview
iOS 14 now shows a notification each time an app accesses the clipboard, so we need to be more careful on when to read it. It also has a new API that allows apps to tell if there's any content on the clipboard or not. The API has more methods than the one I implemented, I just added the one I needed. I don't have time to keep working on this unfortunately to add the rest of the methods :( I understand if you think this is not enough to merge.
Test Plan
Unfortunately, the example project didn't compile for me, so I couldn't use that one to test, I tested directly on my own project.
To test you need an iOS 14 device and one with an older version. On both of them add a call somewhere to
await Clipboard.hasString(). Do so while having content on the clipboard and while having an empty clipboard. You could print the result of the call toconsole.logor any other logger to see that the correct value is returned.