fix: resolver.resolveRequest is always undefined (#1982)

react-native-community · Jun 22, 2023 · 1539fcd · 1539fcd
1 parent 92bbda9
commit 1539fcd
Showing 1 changed file with 17 additions and 15 deletions.
diff --git a/packages/cli-plugin-metro/src/tools/loadMetroConfig.ts b/packages/cli-plugin-metro/src/tools/loadMetroConfig.ts
@@ -6,6 +6,7 @@ import {
   loadConfig,
   mergeConfig,
   resolveConfig,
+  ResolverConfigT,
 } from 'metro-config';
 import {CLIError, logger} from '@react-native-community/cli-tools';
 import type {Config} from '@react-native-community/cli-types';
@@ -26,23 +27,24 @@ function getOverrideConfig(ctx: ConfigLoadingContext): InputConfigT {
   const outOfTreePlatforms = Object.keys(ctx.platforms).filter(
     (platform) => ctx.platforms[platform].npmPackageName,
   );
+  const resolver: Partial<ResolverConfigT> = {
+    platforms: [...Object.keys(ctx.platforms), 'native'],
+  };
+
+  if (outOfTreePlatforms.length) {
+    resolver.resolveRequest = reactNativePlatformResolver(
+      outOfTreePlatforms.reduce<{[platform: string]: string}>(
+        (result, platform) => {
+          result[platform] = ctx.platforms[platform].npmPackageName!;
+          return result;
+        },
+        {},
+      ),
+    );
+  }
 
   return {
-    resolver: {
-      resolveRequest:
-        outOfTreePlatforms.length === 0
-          ? undefined
-          : reactNativePlatformResolver(
-              outOfTreePlatforms.reduce<{[platform: string]: string}>(
-                (result, platform) => {
-                  result[platform] = ctx.platforms[platform].npmPackageName!;
-                  return result;
-                },
-                {},
-              ),
-            ),
-      platforms: [...Object.keys(ctx.platforms), 'native'],
-    },
+    resolver,
     serializer: {
       // We can include multiple copies of InitializeCore here because metro will
       // only add ones that are already part of the bundle