Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

☂️ cli-platform-apple - further improvements #2217

Closed
9 tasks done
okwasniewski opened this issue Dec 20, 2023 · 3 comments
Closed
9 tasks done

☂️ cli-platform-apple - further improvements #2217

okwasniewski opened this issue Dec 20, 2023 · 3 comments

Comments

@okwasniewski
Copy link
Contributor

okwasniewski commented Dec 20, 2023

Descripiton

cli-platform-apple is a new package introduced for OOT platforms. This issue lists further improvements that can be done to improve the codebase.

  • Remove getFallbackSimulator() and use first available simulator
  • Extract duplicated logic between createRun and createLog commands: feat: add platform-cli-apple with reusable utilities for OOT platforms #2208 (comment)
  • Implement app launching for React Native macOS: PR
  • Move prompt from createLog to prompts.ts: PR
  • Create a getter for buildOptions / runOptions to include proper platformName - PR
  • Modify warning Multiple Podfiles were found to take OOT platforms into account PR
  • Make dependencyConfig into a builder - PR
  • Remove code duplication between createRun and createBuild. Logic to re-check Xcode project can be moved to getXcodeProjectAndDir behind a flag refactor: extract duplicated code to getXcodeProjectAndDir #2220
  • merge buildOptions into runOptions to avoid confusion when importing/extending
@matthargett
Copy link

I think the last item in the list can be check off now, right? Are there any additional/new items we want to add here based on @Saadnajmi observations so far on the macOS side?

@okwasniewski
Copy link
Contributor Author

Thanks @matthargett, I checked off the last item from the list 👍🏻 Can we close this @szymonrybczak or is there something more you want to add under this umbrella issue?

@szymonrybczak
Copy link
Collaborator

Yeah, I think we can close this! Thank you for all contributions @okwasniewski! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants