11.3.10 -> 12.1.1 run-ios --device argument handling regression

[msbit]

Environment

info Fetching system and libraries information...
System:
  OS: macOS 13.6.3
  CPU: (8) arm64 Apple M1
  Memory: 81.67 MB / 16.00 GB
  Shell:
    version: 5.2.15
    path: /opt/local/bin/bash
Binaries:
  Node:
    version: 18.18.2
    path: /opt/local/bin/node
  Yarn:
    version: 1.22.19
    path: ~/bin/yarn
  npm:
    version: 6.14.18
    path: /opt/local/bin/npm
  Watchman:
    version: 2023.05.15.00
    path: /opt/homebrew/bin/watchman
Managers:
  CocoaPods:
    version: 1.14.3
    path: /Users/tom/.rbenv/shims/pod
SDKs:
  iOS SDK:
    Platforms:
      - DriverKit 22.4
      - iOS 16.4
      - macOS 13.3
      - tvOS 16.4
      - watchOS 9.4
  Android SDK:
    API Levels:
      - "21"
      - "24"
      - "27"
      - "29"
      - "30"
      - "31"
      - "33"
      - "34"
    Build Tools:
      - 23.0.1
      - 28.0.3
      - 29.0.2
      - 29.0.3
      - 30.0.2
      - 30.0.3
      - 31.0.0
      - 33.0.0
      - 33.0.1
      - 33.0.2
    System Images:
      - android-33 | Google APIs ARM 64 v8a
    Android NDK: Not Found
IDEs:
  Android Studio: Not Found
  Xcode:
    version: 14.3.1/14E300c
    path: /usr/bin/xcodebuild
Languages:
  Java:
    version: 17.0.9
    path: /usr/bin/javac
  Ruby:
    version: 3.1.4
    path: /Users/tom/.rbenv/shims/ruby
npmPackages:
  "@react-native-community/cli": Not Found
  react:
    installed: 18.2.0
    wanted: 18.2.0
  react-native:
    installed: 0.73.0
    wanted: 0.73.0
  react-native-macos: Not Found
npmGlobalPackages:
  "*react-native*": Not Found
Android:
  hermesEnabled: true
  newArchEnabled: false
iOS:
  hermesEnabled: true
  newArchEnabled: false

Description

Under 11.3.10 (react native 0.72.9) the following runs, but under 12.1.1 (react native 0.73.0) fails:

npx react-native run-ios --mode Debug --device --extra-params '-jobs 7'

The error is:

error: unknown option '-jobs 7'

There is no change in the description of the argument usage here vs here.

Reproduction

pushd $(mktemp -d)
npx react-native init --version 0.73.0 foobar
pushd foobar
npx react-native run-ios --mode Debug --device --extra-params '-jobs 7'

[szymonrybczak]

hey @msbit, I think we changed something how we're receiving command flags. But I don't quite understand the use case of passing --device without any value? Why are you trying to do it?

[msbit]

Hey @szymonrybczak I'm passing it to ensure it runs on my attached device, not the simulator. Is it no longer required to do that (both/either for iOS and Android)?