Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow users to specify --device without value #2263

Merged

Conversation

szymonrybczak
Copy link
Collaborator

Summary:

Fixes #2262.

In #2078 --device was accidentally removed, and in #2086 the flag was restored, but with a small change where now --device flag accept value wrapped <> instead of []:

that caused a regression, because with <> value is required, but with [] is optional.

Test Plan:

  1. Clone the repository and do all the required steps from the Contributing guide
  2. Plug physical device to computer
  3. Run this command:
node /path/to/react-native-cli/packages/cli/build/bin.js run-ios --device
  1. First physical device should be picked:
❯ yarn ios --device
yarn run v1.22.19
$ react-native run-ios --device
info Found Xcode workspace "RN0732.xcworkspace"
info Using first available device named "iPhone Szymon" due to lack of name supplied.

Checklist

  • Documentation is up to date to reflect these changes.
  • Follows commit message convention described in CONTRIBUTING.md

@thymikee thymikee merged commit ac90938 into main Jan 16, 2024
10 checks passed
@thymikee thymikee deleted the fix/regression-allow-running-only-on-physical-devices branch January 16, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

11.3.10 -> 12.1.1 run-ios --device argument handling regression
3 participants