fix: pick correct TARGET_BUILD_DIR for run-ios

[FDiskas]

Summary:

Related: facebook/react-native#21303
Related: facebook/react-native#14423

Test Plan:

I'm getting wrong build target because some pods are also specified a target and this was in xcode env. The grep just matches first but not always the right TARGET. So instead of matching use JSON parsing.

[FDiskas]

In my case xcode ENV causing this error was:

...
PODS_ROOT = /Users/***/client-app/ios/Pods\n' +
PODS_TARGET_SRCROOT = /Users/***/client-app/ios/Pods/../../node_modules/react-native\n' +
PRECOMPS_INCLUDE_HEADERS_FROM_BUILT_PRODUCTS_DIR = YES\n' +
PRECOMP_DESTINATION_DIR = /Users/***/client-app/ios/build/Pods.build/***-Dev-Debug-iphonesimulator/React.build/PrefixHeaders\n' +
PRESERVE_DEAD_CODE_INITS_AND_TERMS = NO\n' +
PRODUCT_BUNDLE_IDENTIFIER = org.cocoapods.React\n' +
PRODUCT_MODULE_NAME = React\n' +
PRODUCT_NAME = React\n' +
PRODUCT_SETTINGS_PATH = \n' +
...
TARGETNAME = React\n' +
TARGET_BUILD_DIR = /Users/***/client-app/ios/build/***-Dev-Debug-iphonesimulator/React\n' +

And that React - i'm not sure where it come from.

[FDiskas]

Also there more build settings in react-native init - there is a differences https://www.diffchecker.com/B6LgFARh

[FDiskas]

Tested on my broken project (now works) and also tested on react-native boilerplate also works

[janicduplessis]

@leethree Could you verify if this fixes your issue?

[FDiskas]

Yes it does

[FDiskas]

More info about WRAPPER_EXTENSION setting

For building an application the value of this variable will be app and for a unit test it will be xctest. This will then create a variable reference to either $(CURRENT_PROJECT_VERSION_app) or $(CURRENT_PROJECT_VERSION_xctest) and assign the respective value associated with that to CURRENT_PROJECT_VERSION.

Reference: https://pewpewthespells.com/blog/xcconfig_guide.html

[emac3]

would have been nice to have this for cli ^3.0.0 (react-native ^0.61.0), 'cause this fixes my issue where I had the wrong TARGET_BUILD_DIR: "/Users//Library/Developer/Xcode/DerivedData/<project_name>/Build/Products/Debug-iphonesimulator/React/<app_name>.app" (instead of "/Users//Library/Developer/Xcode/DerivedData/<project_name>/Build/Products/Debug-iphonesimulator/<app_name>.app")

[FDiskas]

React > v0.62.0 has this

[thymikee]

I think we could cherry-pick this to 3.x