Ignore case in validatePackageName #1660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently `validatePackageName` fails for package names containing uppercase letters. A message like this is shown during pod install: ``` warn Invalid application's package name "com.lugg.ReactNativeConfig" in 'AndroidManifest.xml'. Read guidelines for setting the package name here: https://developer.android.com/studio/build/application-id warn Invalid application's package name "com.BV.LinearGradient" in 'AndroidManifest.xml'. Read guidelines for setting the package name here: https://developer.android.com/studio/build/application-id warn Invalid application's package name "com.lugg.ReactNativeConfig" in 'AndroidManifest.xml'. Read guidelines for setting the package name here: https://developer.android.com/studio/build/application-id warn Invalid application's package name "com.BV.LinearGradient" in 'AndroidManifest.xml'. Read guidelines for setting the package name here: https://developer.android.com/studio/build/application-id ``` However both the package name (https://developer.android.com/guide/topics/manifest/manifest-element.html#package) and the application id (https://developer.android.com/studio/build/application-id) are allowed to contain upper case letters. This change adds the "i" flag to the regex to ignore case when validating package name. Related issue: facebook/react-native#34247
|
Do you think this is gonna fix |
|
@matinzd It will not fix pod install calling android specific configuration. I am not familiar enough with the code in this repo to know how to do that. It fixes only it considering valid package names as invalid. |
matinzd
approved these changes
Jul 28, 2022
There was a problem hiding this comment.
Looks good to me, but the problem I have with this is why getAndroidProject should be called via pod install?
I think this needs to be fixed in cli bin with passing params. If it's gradle running the script, android should be checked and if this is being called from native_modules in the ruby script, only ios should only be called.
|
Thanks! Looks good. Can you please add a test with this case? |
|
@matinzd right, we could add a |
|
@thymikee Added a few tests for |
thymikee
approved these changes
Jul 28, 2022
thymikee
pushed a commit
that referenced
this pull request
Jul 28, 2022
* Ignore case in validatePackageName Currently `validatePackageName` fails for package names containing uppercase letters. A message like this is shown during pod install: ``` warn Invalid application's package name "com.lugg.ReactNativeConfig" in 'AndroidManifest.xml'. Read guidelines for setting the package name here: https://developer.android.com/studio/build/application-id warn Invalid application's package name "com.BV.LinearGradient" in 'AndroidManifest.xml'. Read guidelines for setting the package name here: https://developer.android.com/studio/build/application-id warn Invalid application's package name "com.lugg.ReactNativeConfig" in 'AndroidManifest.xml'. Read guidelines for setting the package name here: https://developer.android.com/studio/build/application-id warn Invalid application's package name "com.BV.LinearGradient" in 'AndroidManifest.xml'. Read guidelines for setting the package name here: https://developer.android.com/studio/build/application-id ``` However both the package name (https://developer.android.com/guide/topics/manifest/manifest-element.html#package) and the application id (https://developer.android.com/studio/build/application-id) are allowed to contain upper case letters. This change adds the "i" flag to the regex to ignore case when validating package name. Related issue: facebook/react-native#34247 * Add tests for validatePackageName
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Currently
validatePackageNamefails for package names containing uppercase letters. A message like this is shown during pod install:However both the package name (https://developer.android.com/guide/topics/manifest/manifest-element.html#package) and the application id (https://developer.android.com/studio/build/application-id) are allowed to contain upper case letters.
This change adds the "i" flag to the regex to ignore case when validating package name.
Related issue: facebook/react-native#34247
Test Plan:
I verified in browser console that the updated regex works correctly:
