fix: add missing argument to xcodebuild shell (destination)

[MichelBahl]

• destination is used for to specify the arch for iOS build
• this is needed for modules which require arch x84_64

Summary:

With the destination build parameter it can be specified what destination (arch x86_64) gonna be used to build iOS

In case you are using an apple silicon Mac to build your app and you are using Pod dependencies which were not made for apple silicon it were not possible to change the arch for these dependencies from cli.

Error:
could not find module 'Adyen' for target 'arm64-apple-ios-simulator'; found: x86_64-apple-ios-simulator, at:

xcode would prompt to Build for Rosetta and add en config file

And create a settings file (which has no effect for cli build):

Test Plan:

1. Install this fork
2. Run following command npx react-native run-ios --simulator="iPhone 14 Pro" --destination arch=x86_64

[adamTrz]

Hi @MichelBahl thanks for the PR! 💪

Looks like prettier check is failing? 🤔 Mind resolving that?
Also, why there're all those changes in yarn.lock file? :)

[MichelBahl]

Removed changes in yarn.lock

[uloco]

I'd like to test this but have no clue how to install this fork in my project since it is bundled into react-native....

[adamTrz]

I'd like to test this but have no clue how to install this fork in my project since it is bundled into react-native....

Here's the guide :)

Basically you have to pull the fork (you can use GH CLI to do it or do it manually with git cmd ) and link it.
Then you should be able to test changes by running react-native commands against cloned repo

[uloco]

@adamTrz I followed that guide but I still get error: unknown option '--destination' error

EDIT: Oh my bad I was on the wrong branch. Trying again 😓

[uloco]

Now I'm getting this:

npx react-native run-ios --simulator="iPhone 14 Pro" --destination arch=x86_64
node:internal/modules/cjs/loader:1050
  throw err;
  ^

Error: Cannot find module '@react-native-community/cli-tools'
Require stack:
- /Users/uloco/Source/forks/cli/packages/cli/build/commands/init/errors/InvalidNameError.js
- /Users/uloco/Source/forks/cli/packages/cli/build/commands/init/validate.js
- /Users/uloco/Source/forks/cli/packages/cli/build/commands/init/init.js
- /Users/uloco/Source/forks/cli/packages/cli/build/commands/init/index.js
- /Users/uloco/Source/forks/cli/packages/cli/build/commands/index.js
- /Users/uloco/Source/forks/cli/packages/cli/build/index.js
- /Users/uloco/Source/RN71/node_modules/react-native/cli.js
    at Module._resolveFilename (node:internal/modules/cjs/loader:1047:15)
    at Module._load (node:internal/modules/cjs/loader:893:27)
    at Module.require (node:internal/modules/cjs/loader:1113:19)
    at require (node:internal/modules/cjs/helpers:103:18)
    at _cliTools (/Users/uloco/Source/forks/cli/packages/cli/build/commands/init/errors/InvalidNameError.js:8:16)
    at Object.<anonymous> (/Users/uloco/Source/forks/cli/packages/cli/build/commands/init/errors/InvalidNameError.js:14:32)
    at Module._compile (node:internal/modules/cjs/loader:1226:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1280:10)
    at Module.load (node:internal/modules/cjs/loader:1089:32)
    at Module._load (node:internal/modules/cjs/loader:930:12) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '/Users/uloco/Source/forks/cli/packages/cli/build/commands/init/errors/InvalidNameError.js',
    '/Users/uloco/Source/forks/cli/packages/cli/build/commands/init/validate.js',
    '/Users/uloco/Source/forks/cli/packages/cli/build/commands/init/init.js',
    '/Users/uloco/Source/forks/cli/packages/cli/build/commands/init/index.js',
    '/Users/uloco/Source/forks/cli/packages/cli/build/commands/index.js',
    '/Users/uloco/Source/forks/cli/packages/cli/build/index.js',
    '/Users/uloco/Source/RN71/node_modules/react-native/cli.js'
  ]
}

Node.js v18.14.0

But I linked them correctly and I can also see the link in the links folder.
I created a new RN project because I thought it is related to my project but dunno.....

[uloco]

Looks like I needed to go into the linked directory and run yarn again. Build is running now, let's see if it runs through.

[uloco]

IT WORKED! 🎉 🚀

[szymonrybczak]

Works great! Thank you for contribution! 🎉

[szymonrybczak]

Please add this flag to the docs.

[MichelBahl]

Added to docs

[domthomhive]

What version of react-native and the cli is this option available from? Doesn't seem to work in 0.70.14 with cli version 9.2.1. Thanks

[szymonrybczak]

hey @domthomhive, it's available since 0.72 (CLI version: 11.x).

[medjamiaanes]

2. npx react-native run-ios --simulator="iPhone 14 Pro" --destination arch=x86_64

It's throwing unknown option '--destination' for me :/ . Any idea ?

[szymonrybczak]

Hey @medjamiaanes, are you sure that you correctly linked packages? (Please follow steps described here)