fix: init when there's a package.json in folder #1980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szymonrybczak
approved these changes
Jun 22, 2023
|
FYI I checked if links generation works correctly. It works same as before. ✅ |
kelset
approved these changes
Jun 22, 2023
There was a problem hiding this comment.
can confirm that the fix work, managed to test locally to generate the diff patch for upgrade-helper and by locally using this fix everything worked 👍
react-native-community/rn-diff-purge@6ba5199
let's merge this one, cp into 11.x and create a new CLI release :) no rush though, atm we're aiming at doing 0.72.1 early next week
thymikee
added a commit
that referenced
this pull request
Jun 22, 2023
* fix: init when there's a package.json in folder * test: update snapshots --------- Co-authored-by: szymonrybczak <szymon.rybczak@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
When
initin a folder that contains any kind ofpackage.jsonthe failed with:This is due to
reactNativeVersionintroduced in #1870 accessing theinitialConfig.reactNativePathgetter, which throws in situations where there's nopackage.jsonfile available in the directory. Reading this infinalConfigis fine, because when there's nopackage.json, it skips the logic inside the.reduce, which accessesinitialConfig.reactNativePathvariable.Tbh, this is rather convoluted logic and because of that during code review we failed identifying it as a potential problem. Let's treat this as a band-aid for now and as a followup think about refactoring this piece.
Test Plan:
I haven't really tested the versioned link generation, so please make sure to verify it