Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): properly pass port to env in xcodebuild #2245

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

szymonrybczak
Copy link
Collaborator

@szymonrybczak szymonrybczak commented Jan 7, 2024

Summary:

Fixes #2228

When passing --port to run-ios command it is of type number:

Test Plan:

  1. Clone the repository and do all the required steps from the Contributing guide
  2. Run this command:
node /path/to/react-native-cli/packages/cli/build/bin.js run-ios --port 8888
  1. Simulator should connect to a dev server on 8888 port.
Online.Converter.video.Jan.7.mp4

Checklist

  • Documentation is up to date to reflect these changes.
  • Follows commit message convention described in CONTRIBUTING.md

@github-actions github-actions bot added the bugfix label Jan 7, 2024
@szymonrybczak szymonrybczak changed the title fix(ios): types when passing port to env in xcodebuild fix(ios): properly pass port to env in xcodebuild Jan 7, 2024
@szymonrybczak
Copy link
Collaborator Author

CI failure not related to changes, it is failing because it can't install Cocoapods, because of the issue with boost - (more context: facebook/react-native#42109)

@thymikee thymikee merged commit 453fe0c into main Jan 8, 2024
7 of 10 checks passed
@thymikee thymikee deleted the fix/properly-pass-port-to-env branch January 8, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom port on ios does not work after react-native upgrade to 0.73
2 participants