chore: RFC-0759 remove profile-hermes #2316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szymonrybczak
changed the title
RFC-0759 [1] asks for the removal of this command from the community CLI. This is a legacy method of gathering profiling data for Android only. It has been superseded by the experimental debugger [2], which connects to the CDP server and gathers the these profiles for iOS and Android using the CDP Profile domain [3]. [1] https://github.com/react-native-community/discussions-and-proposals/blob/main/proposals/0759-react-native-frameworks.md#community-cli [2] https://reactnative.dev/docs/next/debugging?js-debugger=new-debugger#opening-the-debugger [3] https://cdpstatus.reactnative.dev/devtools-protocol/tot/Profiler
blakef
force-pushed
the
rfc-0759-remove-hermes-profiler
branch
from
0d84172
to
0f08567
Compare
|
Can we also update |
blakef
added a commit
to facebook/react-native-website
that referenced
this pull request
Mar 5, 2024
Part of RFC-0759, this was removed here: react-native-community/cli/pull/2316
|
Thanks for pointing this out, PR is up: facebook/react-native-website/pull/4037 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
RFC-0759 [1] asks for the removal of this command from the community CLI. This is a legacy method of gathering profiling data for Android only. It has been superseded by the experimental debugger [2], which connects to the CDP server and gathers the these profiles for iOS and Android using the CDP Profile domain [3].
I've also removed all references to it that I could find the markdown docs.
[1] https://github.com/react-native-community/discussions-and-proposals/blob/main/proposals/0759-react-native-frameworks.md#community-cli
[2] https://reactnative.dev/docs/next/debugging?js-debugger=new-debugger#opening-the-debugger
[3] https://cdpstatus.reactnative.dev/devtools-protocol/tot/Profiler
Test Plan:
Build & ran
./packages/cli/dist/bin.jsto confirm it was no longer present.Checklist