feat: RFC-0759: command clean → @react-native/core-cli-utils #2331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blakef
commented
Mar 15, 2024
blakef
force-pushed
the
rfc-0759-clean-command
branch
from
8a0bb61
to
e666085
Compare
Use the core library for clean actions. TODO: strip out local linking before landing this commit!
blakef
force-pushed
the
rfc-0759-clean-command
branch
from
e666085
to
f92e72f
Compare
cortinico
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Use the core library for clean actions. This is blocked by facebook/react-native#43531 landing in nightlies.
Warning
This needs to wait for nightlies to land with the updated TypeScript definitions, expect CI to fail until then.
Test Plan:
Checklist