Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(e2e): sync with React Native 0.74 #2376

Merged
merged 4 commits into from
May 8, 2024
Merged

Conversation

szymonrybczak
Copy link
Collaborator

Summary:

React Native was released two weeks ago, in this Pull Request I've synced our e2e infra to unblock CI.

Test Plan:

CI Green.

Checklist

  • Documentation is up to date to reflect these changes.
  • Follows commit message convention described in CONTRIBUTING.md

@szymonrybczak
Copy link
Collaborator Author

@thymikee Some time ago, we added running CI also on release branches. I think it may be worth adding passing a specific version to the init command so that the testing project will be bootstrapped with the correct React Native version. It's a small effort, but it can save us some time with edge cases :) WDYT?

@thymikee
Copy link
Member

thymikee commented May 6, 2024

Let's do it

@thymikee thymikee merged commit 87881ef into main May 8, 2024
8 of 10 checks passed
@thymikee thymikee deleted the fix/e2e/update-snapshots branch May 8, 2024 10:32
@thymikee
Copy link
Member

thymikee commented May 8, 2024

Let's merge this and work on Windows fixes separately. Thanks @szymonrybczak!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants