fix: update react-native version in the template for versions >= 0.75. #2417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blakef
requested review from
szymonrybczak
and removed request for
thymikee and
adamTrz
blakef
force-pushed
the
fix/new-template-set-react-version
branch
2 times, most recently
from
2887f96
to
4e3eb5a
Compare
cipolleschi
reviewed
Jun 19, 2024
|
Discussed offline with @blakef: We also need all the deps inside |
Done. |
blakef
force-pushed
the
fix/new-template-set-react-version
branch
from
271bcc8
to
eb3d337
Compare
cortinico
reviewed
Jun 19, 2024
cortinico
reviewed
Jun 19, 2024
blakef
force-pushed
the
fix/new-template-set-react-version
branch
2 times, most recently
from
bdf287d
to
9e4131b
Compare
The new template handling in @react-native-community/template means that these are shipped with version 1000.0.0 for React Native. The CLI now owns this.
1. Allow using both of these, but only when the user specifies a version of react-native >= 0.75. Since templates are now detached there are valid use cases for developers and users to specify a template. Added a warning about this test(scope): title 2. Exit early for 0.75+ when we can't find a matching @react-native-community/template to the version of react-native. These should always be matching, but allow for users to remidy this by specifying a template. Clearly this should never happen though. I've also gone to some effort to use concrete versions in the code when tags are passed. E.g. --version next, currently maps to 0.75.0-rc0. We use the latter when looking up templates.
From 0.75 our @react-native/ dependencies must match the version of react-native. Updated init to perform this on @react-native-community/template.
blakef
force-pushed
the
fix/new-template-set-react-version
branch
from
9e4131b
to
fba1546
Compare
cortinico
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new template handling in @react-native-community/template means that these are shipped with version 1000.0.0 for React Native. The CLI now owns having to update to the correct version.
NOTE: This will only apply if the template has a
react-native@1000.0.0, i.e. is from@react-native-community/template.Summary:
--templateand--versionwhen--versionis >= 0.75. Added a warning about doing this, but it's valid if the user gets into trouble or more advanced users want to do fun stuff.@react-native/scoped dependencies must match the version ofreact-native.initnow enforces this.@react-native-community/templatewill release matching version for each React Native release. It's important to normalise version at the time of constructing the project otherwise the template will gradually become invalidate asreact-native@latest(for example) moves.For example, now running:
Updated
react-nativeversion on templateAdded some logs for the version update in the template
Scoped Version Matching
Test Plan:
Checklist