Remove hardcoded React Native configuration #767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thymikee
approved these changes
Oct 3, 2019
| @@ -79,8 +105,7 @@ test('should return dependencies from package.json', () => { | |||
|
|
|||
| test('should read a config of a dependency and use it to load other settings', () => { | |||
| writeFiles(DIR, { | |||
| 'node_modules/react-native/package.json': '{}', | |||
| 'node_modules/react-native-test/package.json': '{}', | |||
There was a problem hiding this comment.
Accident, but I am surprised that the tests are passing.
|
Tests are failing on Windows. I will need a Windows machine to debug why the mocking logic doesn't work. If there's anybody with Windows that's willing to give it a go, let me know! |
|
@thecodrr would you like to help us debug this? |
|
Yup. On it. |
thymikee
force-pushed
the
feat/decouple-cli-from-native
branch
from
114fedc
to
307f50b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Historically, React Native used to be tightly coupled with the CLI, support for Android and iOS was hardcoded. Since 0.60, we have made React Native ship with its own configuration, specifying Android and iOS platforms just like React Native Windows.
This PR removes "dead-code" that was only needed during the transition period. It wasn't used and called in the 0.60.
I have also removed some obsolete tests that were no longer needed.